-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verbose flag #59
Verbose flag #59
Conversation
3821624
to
47cc638
Compare
515a3fa
to
3c41278
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on the update & nice find with consola!
Besides the code comments, also some general remarks:
Some merge conflicts still outstanding
Tested commands:
- run-test: OK
- import-reconciliation: OK
- update-reconciliation: OK
- get-reconciliation-id: No output of success
consola.prompt for authorization flow
Consola also has a prompt function, for the authorization command, it wouldn't be too big of a refactor to already use this.
Created separate issue to integrate this for the rest of the commands: #83
consola.info(
`NOTE: if you need to exit this process you can press "Ctrl/Cmmd + C"`
);
const redirectUri = "urn%3Aietf%3Awg%3Aoauth%3A2.0%3Aoob";
const scope =
"administration%3Aread%20administration%3Awrite%20financials%3Aread%20financials%3Awrite%20workflows%3Aread";
const firmIdPrompt = await consola.prompt("Enter the firm ID: ", {
initial: firmId,
});
const url = `${apiUtils.BASE_URL}/f/${firmIdPrompt}/oauth/authorize?client_id=${process.env.SF_API_CLIENT_ID}&redirect_uri=${redirectUri}&response_type=code&scope=${scope}`;
await open(url);
consola.info(`You need to authorize your APP in the browser`);
consola.info("Insert your credentials...");
const authCodePrompt = await consola.prompt(
"Enter your API authorization code: ",
{
echo: "*",
}
);
5f11d77
to
2e7bd41
Compare
Changes implemented. Also rebased (again) from export-files to align. |
2e7bd41
to
08ea53d
Compare
ddd6c1d
to
c42681f
Compare
c42681f
to
c95f685
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as well to go live!
Description
Implement the use of package
consola
Differentiate different output types
error
,log
,debug
,info
,success
,warn
By default use a level of
info
.Add the
--verbose
flag which will set the the level todebug
.Fixes #37
BLOCKED BY: #56BLOCKED BY: #57BLOCKED BY: #50Type of change
Checklist