Add SH4 support #114
Merged
Add SH4 support #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonlindholm
approved these changes
Jun 26, 2023
diff.py
Outdated
| r"r1[0-5]|r[0-9]|fr1[0-5]|fr[0-9]|dr[02468]|dr1[024]|xd[02468]|xd1[024]|fv[048]|fv12" | ||
| ), | ||
| arch_flags=["-m", "sh4"], | ||
| proc=AsmProcessorSH4, |
There was a problem hiding this comment.
maybe we should use AsmProcessorSH2 instead of defining a new one? I don't know enough about the arch to say whether there are any cases where we have to treat them differently, so I'll let you decide
There was a problem hiding this comment.
AFAIK there aren't (and won't be) any differences between the two AsmProcessors -- I'll remove AsmProcessorSH4 then
sozud
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic Hitachi SH4 support. Based off @sozud's work on SH2 which means it also relates to #113