Use comments to apply relocations to certain instructions #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonlindholm
approved these changes
Jun 13, 2024
1superchip
added a commit
to 1superchip/decomp.me
that referenced
this pull request
Oct 6, 2024
mkst
pushed a commit
to decompme/decomp.me
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #161
This is an attempt to fix an issue with the assembler not emitting relocations to static functions.
This may cause issues when absolute values are used such as in this scratch: https://decomp.me/scratch/KBprJ
The input assembly of the scratch is
bl 4which objdump disassembles toHow asm-differ outputs this with my changes:
Other instructions could be added but would cause issues such as conditional/unconditional branches to labels within functions
This scratch has labels which the assembler emits: https://decomp.me/scratch/hKpwa
objdump of the input assembly from the scratch:
These branch instructions have a comment which matches the comment regex that is used in AsmProcessorPPC.pre_process so the offsets (which we want) would get replaced with the label if these instructions are included.
This is why AsmProcessorPPC.pre_process checks for
bl