Clear Windows Terminal buffer before diffing #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonlindholm
requested changes
Mar 25, 2021
| # Janky hack to clear its scrollback buffer until it's fixed | ||
| clear_proc = subprocess.Popen( | ||
| ["echo", "-en", "\"\e[3J\""] | ||
| ) |
There was a problem hiding this comment.
Popen() starts a new process that runs asynchronously; we'd need to wait for it to finish if we do this (clear_proc.wait() or subprocess.run()/similar). Does it work if you instead do
sys.stdout.write("\x1b7[3J\"")
sys.stdout.flush()?
There is a os.system("tput reset") further down which is similar to this btw, but I guess it doesn't help for whatever reason (and it doesn't do anything for the very first less call).
There was a problem hiding this comment.
The stdout writes don't work unfortunately. It looks like tput reset does work as well, but the issue I have with that is that it clears all of your previous console output after closing the diff, but it's nice to keep previous commands visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows Terminal doesn't clear its buffers properly and scrolling is all screwy. Diffs don't open with new buffers, and it's possible to scroll up to view previous console output. This workaround forces a clear which clears that out. If there's a better way/place to do this, let me know.