Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization of wishlist/wishlistitem in sql #1099

Merged
merged 1 commit into from
May 10, 2024

Conversation

domino14
Copy link
Contributor

@domino14 domino14 commented May 8, 2024

The capitalization of the database table WishList_WishListItem was wrong for non-MSSQL databases; this resulted in a 500 when trying to reset the catalog.

@hishamco
Copy link
Member

hishamco commented May 8, 2024

You meanWishlist_Wishlistitem

@domino14
Copy link
Contributor Author

domino14 commented May 9, 2024

The tables as they were created on my Postgres database are WishList_WishListItem and WishList_WishList. The .sql files I am correcting have it spelled as Wishlist_Wishlistitem and Wishlist_Wishlist prior to correction.

@hishamco
Copy link
Member

hishamco commented May 9, 2024

@thiennn do you have any objections or shall I merge?

@thiennn thiennn merged commit 230310c into simplcommerce:master May 10, 2024
8 checks passed
@domino14 domino14 deleted the fix-wishlist-item-sql branch May 10, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants