-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Ualpha and Ubeta to FOCMotor #326
Conversation
I just forgot it's also used here |
Hmmm - it looks here like a bunch of the AVR checks are failing. I think we have to look into why before we can merge it... |
Welcome back and thanks for merging the PRs. I am trying to keep each PR minimal, I hope it's ok. |
I tried removing Ualpha and Ubeta from StepperMotor.h also and initializing it in FOCMotor.cpp, but no luck. I am cursed: |
Weird, right? I haven't really figured out what it is... But in the meantime I have found and fixed the various esp32 compile problems, of which there were several. None of them had anything to do with your changes, as expected. |
If you merge over my recent changes I think that will fix the ESP32 side of things, at least |
Merge new dev changes
Merges all the last dev changes fixed ESP32 compilation as you said, but avr is still failing. |
I think the avr issue is fixed so I'm merging this. :D |
This is just about moving Ualpha and Ubeta to FOCMotor so it's available to the flux observer sensor.