Merge master into release-5.x #2825
php.yml
on: push
Annotations
29 errors and 27 warnings
InvalidArgument:
src/SAML2/Assertion/Transformer/NameIdDecryptionTransformer.php#L101
src/SAML2/Assertion/Transformer/NameIdDecryptionTransformer.php:101:25: InvalidArgument: Argument 1 of SimpleSAML\SAML2\XML\saml\Subject::__construct expects SimpleSAML\SAML2\XML\saml\IdentifierInterface|null, but SimpleSAML\XML\SerializableElementInterface provided (see https://psalm.dev/004)
|
MissingTemplateParam:
src/SAML2/Certificate/Key.php#L19
src/SAML2/Certificate/Key.php:19:22: MissingTemplateParam: SimpleSAML\SAML2\Certificate\Key has missing template params when extending ArrayAccess, expecting 2 (see https://psalm.dev/182)
|
UndefinedClass:
src/SAML2/Certificate/PrivateKeyLoader.php#L48
src/SAML2/Certificate/PrivateKeyLoader.php:48:24: UndefinedClass: Class, interface or enum named SimpleSAML\XMLSecurity\XMLSecurityKey does not exist (see https://psalm.dev/019)
|
UndefinedClass:
src/SAML2/Certificate/PrivateKeyLoader.php#L48
src/SAML2/Certificate/PrivateKeyLoader.php:48:39: UndefinedClass: Class, interface or enum named SimpleSAML\XMLSecurity\XMLSecurityKey does not exist (see https://psalm.dev/019)
|
UndefinedClass:
src/SAML2/Certificate/PrivateKeyLoader.php#L74
src/SAML2/Certificate/PrivateKeyLoader.php:74:73: UndefinedClass: Class, interface or enum named SimpleSAML\XMLSecurity\XMLSecurityKey does not exist (see https://psalm.dev/019)
|
TypeDoesNotContainNull:
src/SAML2/HTTPArtifact.php#L76
src/SAML2/HTTPArtifact.php:76:31: TypeDoesNotContainNull: DOMDocument does not contain null (see https://psalm.dev/090)
|
RedundantCondition:
src/SAML2/HTTPArtifact.php#L76
src/SAML2/HTTPArtifact.php:76:31: RedundantCondition: Type DOMDocument for $__tmp_nullsafe__2376 is never null (see https://psalm.dev/122)
|
UndefinedClass:
src/SAML2/HTTPArtifact.php#L95
src/SAML2/HTTPArtifact.php:95:16: UndefinedClass: Class, interface or enum named SimpleSAML\Utils\HTTP does not exist (see https://psalm.dev/019)
|
UndefinedClass:
src/SAML2/HTTPArtifact.php#L168
src/SAML2/HTTPArtifact.php:168:30: UndefinedClass: Class, interface or enum named SimpleSAML\Configuration does not exist (see https://psalm.dev/019)
|
NullArgument:
src/SAML2/HTTPArtifact.php#L171
src/SAML2/HTTPArtifact.php:171:54: NullArgument: Argument 2 of SimpleSAML\SAML2\XML\samlp\ArtifactResolve::__construct cannot be null, null value provided to parameter with type DateTimeImmutable (see https://psalm.dev/057)
|
UndefinedPropertyFetch:
tests/SAML2/XML/md/EncryptionMethodTest.php#L111
tests/SAML2/XML/md/EncryptionMethodTest.php:111:35: UndefinedPropertyFetch: Instance property DOMNameSpaceNode::$textContent is not defined (see https://psalm.dev/039)
|
UndefinedPropertyFetch:
tests/SAML2/XML/mdui/UIInfoTest.php#L162
tests/SAML2/XML/mdui/UIInfoTest.php:162:61: UndefinedPropertyFetch: Instance property DOMNameSpaceNode::$textContent is not defined (see https://psalm.dev/039)
|
TypeDoesNotContainNull:
tests/SAML2/XML/saml/AssertionTest.php#L318
tests/SAML2/XML/saml/AssertionTest.php:318:29: TypeDoesNotContainNull: DOMDocument does not contain null (see https://psalm.dev/090)
|
RedundantCondition:
tests/SAML2/XML/saml/AssertionTest.php#L318
tests/SAML2/XML/saml/AssertionTest.php:318:29: RedundantCondition: Type DOMDocument for $__tmp_nullsafe__11377 is never null (see https://psalm.dev/122)
|
TypeDoesNotContainNull:
tests/SAML2/XML/saml/AssertionTest.php#L581
tests/SAML2/XML/saml/AssertionTest.php:581:53: TypeDoesNotContainNull: DOMDocument does not contain null (see https://psalm.dev/090)
|
RedundantCondition:
tests/SAML2/XML/saml/AssertionTest.php#L581
tests/SAML2/XML/saml/AssertionTest.php:581:53: RedundantCondition: Type DOMDocument for $__tmp_nullsafe__23978 is never null (see https://psalm.dev/122)
|
TypeDoesNotContainNull:
tests/SAML2/XML/saml/AssertionTest.php#L676
tests/SAML2/XML/saml/AssertionTest.php:676:53: TypeDoesNotContainNull: DOMDocument does not contain null (see https://psalm.dev/090)
|
RedundantCondition:
tests/SAML2/XML/saml/AssertionTest.php#L676
tests/SAML2/XML/saml/AssertionTest.php:676:53: RedundantCondition: Type DOMDocument for $__tmp_nullsafe__28679 is never null (see https://psalm.dev/122)
|
TypeDoesNotContainNull:
tests/SAML2/XML/saml/AssertionTest.php#L1120
tests/SAML2/XML/saml/AssertionTest.php:1120:29: TypeDoesNotContainNull: DOMDocument does not contain null (see https://psalm.dev/090)
|
RedundantCondition:
tests/SAML2/XML/saml/AssertionTest.php#L1120
tests/SAML2/XML/saml/AssertionTest.php:1120:29: RedundantCondition: Type DOMDocument for $__tmp_nullsafe__44818 is never null (see https://psalm.dev/122)
|
Quality control
Process completed with exit code 1.
|
Unit tests, PHP 8.2, ubuntu-latest
Process completed with exit code 2.
|
Unit tests, PHP 8.3, ubuntu-latest
Process completed with exit code 2.
|
Unit tests, PHP 8.1, ubuntu-latest
Process completed with exit code 2.
|
Unit tests, PHP 8.2, windows-latest
Process completed with exit code 1.
|
Unit tests, PHP 8.1, windows-latest
The job was canceled because "windows-latest_8_2" failed.
|
Unit tests, PHP 8.1, windows-latest
The operation was canceled.
|
Unit tests, PHP 8.3, windows-latest
The job was canceled because "windows-latest_8_2" failed.
|
Unit tests, PHP 8.3, windows-latest
The operation was canceled.
|
Security checks
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Quality control
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
RiskyTruthyFalsyComparison:
src/SAML2/Assertion/Validation/ConstraintValidator/SubjectConfirmationRecipientMatches.php#L41
src/SAML2/Assertion/Validation/ConstraintValidator/SubjectConfirmationRecipientMatches.php:41:13: RiskyTruthyFalsyComparison: Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
RiskyTruthyFalsyComparison:
src/SAML2/Assertion/Validation/ConstraintValidator/SubjectConfirmationResponseToMatches.php#L42
src/SAML2/Assertion/Validation/ConstraintValidator/SubjectConfirmationResponseToMatches.php:42:13: RiskyTruthyFalsyComparison: Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
PossiblyInvalidArgument:
src/SAML2/Binding.php#L101
src/SAML2/Binding.php:101:53: PossiblyInvalidArgument: Argument 2 of array_key_exists expects array<array-key, mixed>, but possibly different type array<array-key, mixed>|null|object provided (see https://psalm.dev/092)
|
PossiblyInvalidArgument:
src/SAML2/Binding.php#L101
src/SAML2/Binding.php:101:97: PossiblyInvalidArgument: Argument 2 of array_key_exists expects array<array-key, mixed>, but possibly different type array<array-key, mixed>|null|object provided (see https://psalm.dev/092)
|
PossiblyInvalidArgument:
src/SAML2/Binding.php#L103
src/SAML2/Binding.php:103:55: PossiblyInvalidArgument: Argument 2 of array_key_exists expects array<array-key, mixed>, but possibly different type array<array-key, mixed>|null|object provided (see https://psalm.dev/092)
|
MissingClassConstType:
src/SAML2/Certificate/Key.php#L22
src/SAML2/Certificate/Key.php:22:18: MissingClassConstType: Class constant "SimpleSAML\SAML2\Certificate\Key::USAGE_SIGNING" should have a declared type. (see https://psalm.dev/359)
|
MissingClassConstType:
src/SAML2/Certificate/Key.php#L24
src/SAML2/Certificate/Key.php:24:18: MissingClassConstType: Class constant "SimpleSAML\SAML2\Certificate\Key::USAGE_ENCRYPTION" should have a declared type. (see https://psalm.dev/359)
|
RiskyTruthyFalsyComparison:
src/SAML2/Certificate/KeyLoader.php#L108
src/SAML2/Certificate/KeyLoader.php:108:17: RiskyTruthyFalsyComparison: Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
RiskyTruthyFalsyComparison:
src/SAML2/Certificate/PrivateKey.php#L18
src/SAML2/Certificate/PrivateKey.php:18:13: RiskyTruthyFalsyComparison: Operand of type null|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
MissingClassConstType:
src/SAML2/Compat/AbstractContainer.php#L21
src/SAML2/Compat/AbstractContainer.php:21:19: MissingClassConstType: Class constant "SimpleSAML\SAML2\Compat\AbstractContainer::XSI_TYPE_PREFIX" should have a declared type. (see https://psalm.dev/359)
|
PossiblyNullPropertyFetch:
tests/SAML2/XML/md/EncryptionMethodTest.php#L111
tests/SAML2/XML/md/EncryptionMethodTest.php:111:35: PossiblyNullPropertyFetch: Cannot get property on possibly null variable $keySizeElements[0] of type DOMNameSpaceNode|DOMNode|null (see https://psalm.dev/082)
|
PossiblyNullReference:
tests/SAML2/XML/md/EntityDescriptorTest.php#L281
tests/SAML2/XML/md/EntityDescriptorTest.php:281:75: PossiblyNullReference: Cannot call method format on possibly null value (see https://psalm.dev/083)
|
PossiblyNullReference:
tests/SAML2/XML/md/EntityDescriptorTest.php#L398
tests/SAML2/XML/md/EntityDescriptorTest.php:398:89: PossiblyNullReference: Cannot call method format on possibly null value (see https://psalm.dev/083)
|
PossiblyNullReference:
tests/SAML2/XML/md/RoleDescriptorTest.php#L191
tests/SAML2/XML/md/RoleDescriptorTest.php:191:83: PossiblyNullReference: Cannot call method format on possibly null value (see https://psalm.dev/083)
|
PossiblyNullReference:
tests/SAML2/XML/md/RoleDescriptorTest.php#L239
tests/SAML2/XML/md/RoleDescriptorTest.php:239:83: PossiblyNullReference: Cannot call method format on possibly null value (see https://psalm.dev/083)
|
MissingClassConstType:
tests/SAML2/XML/mdui/LogoTest.php#L39
tests/SAML2/XML/mdui/LogoTest.php:39:19: MissingClassConstType: Class constant "SimpleSAML\Test\SAML2\XML\mdui\LogoTest::DATA" should have a declared type. (see https://psalm.dev/359)
|
MissingClassConstType:
tests/SAML2/XML/mdui/LogoTest.php#L44
tests/SAML2/XML/mdui/LogoTest.php:44:19: MissingClassConstType: Class constant "SimpleSAML\Test\SAML2\XML\mdui\LogoTest::URL" should have a declared type. (see https://psalm.dev/359)
|
PossiblyInvalidArgument:
tests/SAML2/XML/mdui/UIInfoTest.php#L155
tests/SAML2/XML/mdui/UIInfoTest.php:155:36: PossiblyInvalidArgument: Argument 1 of SimpleSAML\SAML2\Utils\XPath::getXPath expects DOMNode, but possibly different type DOMNameSpaceNode|DOMNode|null provided (see https://psalm.dev/092)
|
PossiblyInvalidArgument:
tests/SAML2/XML/mdui/UIInfoTest.php#L157
tests/SAML2/XML/mdui/UIInfoTest.php:157:13: PossiblyInvalidArgument: Argument 1 of SimpleSAML\SAML2\Utils\XPath::xpQuery expects DOMNode, but possibly different type DOMNameSpaceNode|DOMNode|null provided (see https://psalm.dev/092)
|
PossiblyNullPropertyFetch:
tests/SAML2/XML/mdui/UIInfoTest.php#L162
tests/SAML2/XML/mdui/UIInfoTest.php:162:61: PossiblyNullPropertyFetch: Cannot get property on possibly null variable $logoElements[0] of type DOMNameSpaceNode|DOMNode|null (see https://psalm.dev/082)
|
Linter
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Unit tests, PHP 8.2, ubuntu-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Unit tests, PHP 8.3, ubuntu-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Unit tests, PHP 8.1, ubuntu-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Unit tests, PHP 8.2, windows-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|