Prefer strict comparisons when using in_array()

simplesamlphp · May 27, 2018 · 5b0a9aa · 5b0a9aa
1 parent b9c92c6
commit 5b0a9aa
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/SAML2/Assertion/Validation/ConstraintValidator/SpIsValidAudience.php b/src/SAML2/Assertion/Validation/ConstraintValidator/SpIsValidAudience.php
@@ -30,7 +30,7 @@ public function validate(Assertion $assertion, Result $result)
         }
 
         $entityId = $this->serviceProvider->getEntityId();
-        if (!in_array($entityId, $intendedAudiences)) {
+        if (!in_array($entityId, $intendedAudiences, true)) {
             $result->addError(sprintf(
                 'The configured Service Provider [%s] is not a valid audience for the assertion. Audiences: [%s]',
                 $entityId,

diff --git a/src/SAML2/AuthnRequest.php b/src/SAML2/AuthnRequest.php
@@ -762,7 +762,7 @@ public function toUnsignedXML()
                                 'ProviderID',
                                 'Loc',
                                 'Name'
-                            ))) {
+                            ), true)) {
                                 $idpEntry->setAttribute($attribute, $value);
                             }
                         }

diff --git a/src/SAML2/Certificate/Key.php b/src/SAML2/Certificate/Key.php
@@ -39,7 +39,7 @@ public function __construct(array $keyData)
      */
     public function canBeUsedFor($usage)
     {
-        if (!in_array($usage, static::getValidKeyUsages())) {
+        if (!in_array($usage, static::getValidKeyUsages(), true)) {
             throw new InvalidKeyUsageException($usage);
         }
 

diff --git a/src/SAML2/Utils.php b/src/SAML2/Utils.php
@@ -125,7 +125,7 @@ public static function castKey(XMLSecurityKey $key, $algorithm, $type = 'public'
             XMLSecurityKey::RSA_SHA256,
             XMLSecurityKey::RSA_SHA384,
             XMLSecurityKey::RSA_SHA512
-        ))) {
+        ), true)) {
             throw new \Exception('Unsupported signing algorithm.');
         }