Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery Pull Request #881

Open
wants to merge 69 commits into
base: main
Choose a base branch
from
Open

Conversation

Jeiii20
Copy link
Collaborator

@Jeiii20 Jeiii20 commented Oct 16, 2024

The old Jeii20 here in a new account. This PR regards all previously closed ones due to my account deletion.

ℹ️ Referrals

This topic reveals all the PR's that have been referred here. Some of the changes are based on the PR's below, whose mention is worth it. You may see these referrals again during the deeper reading of this PR.

⚙️ Changes

This topic describes about all the changes made during the PR progress. It's advisable for the developer to read them carefully to ensure it can really be merged. It's also recommended to check the files changed tab after reading. Check descriptions for each file below.

res/values-ja 🇯🇵

  • Formatting: Changed some of the numbers and latin letters to fullwidth, to fit with the values-ja UI.
  • Correction 1: 「レベル等」 (found at line 889 – "UI_Opacity_") actually means "Level and others", so I changed to "UI" for higher clarity.
  • Correction 2: 「パーティクル」 (found at line 997 – "Particle_Uploads") is way too literal and informal, so I changed to 「粒子」 that's the correct term.
  • Missing strings: Added missing strings compared to res/values (English file). For more details about it, please check the added strings table (link won't work well for mobile app; you may have to scroll down in-app).
  • Translations: Applied translations for lines from 1101 to 1110, 1113, 1114, 1121, 1126, 1137, 1170, 1183, 1186, 1187, 1195, 1196, 1197, 1200, 1202, 1203 and 1204.
  • Inclusions or ommissions: Removed unnecessary spacings at lines 16, 17 and 24; also removed the same at lines that contain placeholders such as %s and %d. This may not affect the formatting in any way.

res/values-tr 🇹🇷

  • Inclusions or ommissions: Re-organised strings. Removed % at line 132. Added 3 other existing commands; they appear at lines 1355, 1356 and 1357.
  • ???: I don't know who made fun with the file, but I removed the additional text they added at line 1340. Actually, the whole admin commands list is oddly mistaken… well, I just had to fix it fully. 🙄
  • For more details, please check Update values-tr (Turkish) #726.

res/values-pt-rBR 🇧🇷

  • Correction 1: Fixed capitals/smalls.
  • Correction 2: Fixed some terms to others that are commonly used.
  • Correction 3: Changed lines 44, 82, 113, 289, 292, 310, 320, 362, 377, 425, 426, 640, 657, 710, 755, 756, 783, 922, 960, 961, 962, 1067, 1069, 1095, 1096, 1103, 1109, 1110, 1221, 1261, 1304, 1310, 1317, 1319, 1330 and 1394 for higher clarity and to fit better with the Portuguese grammar rules.
  • Correction 4: Fixed line 884 for shorter length. "IU" means "Interface de Usuário" respectively.
  • Translations: Applied translations for lines 694 and 1281.
  • For more details, please check Update values-pt-rBR (Portuguese BR) #767.

res/values-ro 🇷🇴

  • Inclusions or ommissions: Replaced quotation mark at line 569 and made apostrophe be appearable at line 1207.
  • Correction 1: Lines 792, 844, 845, 867, 868, 869, 1020, 1021, 1051 and 1228 should be imperative, and not definite.
  • Correction 2: Lines 919, 1014, 1137, 1184, 1224 and 1234 should be verbs without any kind of tense (they usually end with preset "-ă" or "-e" in Romanian).
  • Correction 3: Lines 871, 899, 975, 993, 1018, 1125, 1184, 1190, 1192 and 1230 should be definite nouns (some of them have their genitive included).
  • Correction 4: Lines 943 and 944 are as definite and in these cases, it's wrong.
  • Correction 5: Accents fixed at lines 868 and 1044.
  • Translations: Applied translations for lines 975 and 1184.
  • Missing strings: Added missing strings compared to res/values (English file).
  • For more details, please check Update values-ro (Romanian) #781.

res/values-b+es+r419 🇲🇽

README.md

  • Changed for higher clarity for current/new users on how to get the Translator tag at fair way, as the Translator tag needs to keep its value.
  • A typo has been corrected; found at line 120.
  • For more details, please check Update README.md #766.

res/values-pt-rPT 🇵🇹

  • Correction 1: Corrected interpretation and speech at lines 10, 16, 24, 36, 37, 77, 139, 141, 170, 246, 291, 294, 295, 299, 300, 307, 308, 309, 310, 324, 329, 333, 335, 338, 374, 377 and the whole Nebulous_Rules string.
    Correction 2: Unnecessary or extra spacings removed at lines 35 and 173.
    Correction 3: Fixed lines 71 and 72 for shorter UI, without affecting the meaning.
    Correction 4: Plural candidate fixed at line 83.
    Correction 5: Fixed diacritical accents from circumflex to acute, since in Portugal it's not often used circumflex for nouns, unlike in Brazil's version.
    Inclusions or ommissions: Included commas to fit with portuguese grammar rules at lines 100 and 101. Removed the % at line 131.
  • Missing strings: Added missing strings compared to res/values (English file).

res/values-vi 🇻🇳

  • Correction 1: Fixed lines 1054, 1215, 1217 and 1220 because they seem to be too inconsistent.
  • Correction 2: Changed from "Trang Phục" to "Skin", because translation seems to be too literal at lines 16 and 1040.
  • Correction 3: Placed dots between millennial numbers at lines 405 and 482.
  • Correction 4: "Loại hình" (line 540) doesn't really transmit the meaning for "Team Size", it actually means "Type" or "Kind". Changed to "Kích Thước Đội", that matches way much better with the string.
  • Correction 5: Structures were inverted in previous texts, so changed to meet with the Vietnamese grammar rules; at lines 601 and 1096.
  • Correction 6: "Dùng ảnh" (line 603) or "Ảnh" (line 610), though they transmit a correct meaning and purpose, are not as correct as "Hồ sơ".
  • Correction 7: Fixed capitals and smalls at lines 605, 606, 697, 700, 794, 869, 910, 977, 981, from 984 to 989 and 1096.
  • Correction 8: "Zombie" (lines 794 and 798) is not translated, even though there is an accurate translation for it (thây ma).
  • Correction 9: Provided translation from "Team Deathmatch" to "Deathmatch Đội", at lines 866, 867, 868 and 869.
  • Correction 10: Removed unnecessary spacings at lines 710, 920, 921, 938, 977 and 991.
  • Correction 11: Fixed line 1131, because the text doesn't seem to be right; changed from "hiếm" (rare) to "đặc biệt" (exclusive or special).
  • Translations: Provided translations for lines 1049, 1036, 1134 and 1135; "EULA" (End-User License Agreement) means "TTCPNDC" (Thỏa thuận cấp phép người dùng cuối) in Vietnamese.
  • Missing strings: Added missing strings compared to res/values (English file).

➕️ Added strings in this PR

This table contains a list of missing strings that have been added based on res/values (English file). The tables are split per language.

res/values-ja 🇯🇵

String Line Translated
group_chat_create 1108 No
Specify_Group_ID 1109 No
Joined_group 1111 Yes
People 1112 Yes
new_person_joined 1115 Yes
person_left 1116 Yes
Left_the_group 1117 Yes

res/values-ro 🇷🇴

String Line Translated
Nebulous_Rules 952 to 974 Yes
upload_details 1056 to 1088 Yes
community_skin_information_for_seller 1100 Yes
community_skin_information_for_buyer 1103 Yes
level_color_instructions 1144 Yes
group_chat_create 1163 Yes
Specify_Group_ID 1164 Yes
Joined_group 1166 Yes
People 1167 Yes
new_person_joined 1170 Yes
person_left 1171 Yes
Left_the_group 1172 Yes
skin_trial_info 1186 Yes
mother_cell 1194
shrink 1195
collect_all 1196 Yes
magic_blob 1197 Yes
ice_split 1198
circle 1199 Yes
mega_pop 1200
no_virus 1201 Yes
plasma_hunt 1202 Yes
speed 1203 Yes
shared_pack_info 1208 Yes
shared_pack_purch_description 1209 Yes
multiskin_period_description 1218 Yes
multiskin_description 1220 Yes
poor_connection_quality_warning 1255 Yes
sandbox_warning 1287 Yes
skin_warning 1316 to 1325 Yes
sign_in_explanation 1404 to 1414 Yes

res/values-tr 🇹🇷

String Line Translated
Joined group 1159 Yes
People 1160 Yes
new_person_joined 1163 Yes
person_left 1164 Yes
Left_the_group 1165 Yes
skin_trial_info 1174 Yes
mother_cell 1182 Yes
shrink 1183
collect_all 1184 Yes
magic_blob 1185 Yes
ice_split 1186 Yes
circle 1187 Yes
mega_pop 1188 Yes
no_virus 1189 Yes
plasma_hunt 1190 Yes
speed 1191 Yes
shared_pack_info 1196 Yes
shared_pack_purch_description 1197 Yes
multiskin_period_description 1207 Yes
multiskin_description 1209 Yes
sandbox_warning 1279 Yes
skin_warning 1303 to 1312 Yes

res/values-pt-rPT 🇵🇹

String Line Translated
upload_details 1054 to 1085 Yes
level_color_instructions 1142 Yes
group_chat_create 1161 Yes
Specify_Group_ID 1162 Yes
Joined_group 1164 Yes
People 1165 Yes
new_person_joined 1168 Yes
person_left 1169 Yes
Left_the_group 1170 Yes
skin_trial_info 1184 Yes
mother_cell 1192 Yes
shrink 1193 Yes
collect_all 1194 Yes
magic_blob 1195 Yes
ice_split 1196
circle 1197 Yes
mega_pop 1198
no_virus 1199 Yes
plasma_hunt 1200 Yes
speed 1201 Yes
shared_pack_info 1206 Yes
shared_pack_purch_description 1207 Yes
multiskin_period_description 1217 Yes
multiskin_description 1219 Yes
poor_connection_quality_warning 1252 Yes
sandbox_warning 1284 Yes
skin_warning 1313 to 1322 Yes
sign_in_explanation 1402 to 1412 Yes

res/values-vi 🇻🇳

String Line Translated
Nebulous_Rules 951 to 973 No
upload_details 1055 to 1083 No
community_skin_information_for_seller 1095 No
community_skin_information_for_buyer 1098 Yes
level_color_instructions 1139 No
group_chat_create 1158 Yes
Specify_Group_ID 1159 Yes
Joined_group 1161 Yes
People 1162 Yes
new_person_joined 1165 Yes
person_left 1166 Yes
Left_the_group 1167 Yes
skin_trial_info 1181 No
mother_cell 1189 Yes
shrink 1190 Yes
collect_all 1191 Yes
magic_blob 1192 Yes
ice_split 1193 Yes
circle 1194 Yes
mega_pop 1195
no_virus 1196 Yes
plasma_hunt 1197 Yes
speed 1198 Yes
shared_pack_info 1203 No
shared_pack_purch_description 1204 No
multiskin_period_description 1214 No
multiskin_description 1216 No
poor_connection_quality_warning 1251 No
sandbox_warning 1283 Yes
skin_warning 1312 to 1321 No
sign_in_explanation 1400 to 1412 No

= Means the text is untranslatable in a due language or there's no any specific or accurate meaning for the string.

⚠️ Disclaimer

  • About the files I've managed: A major part of the translations in the files are made by me, all of them are based on what I know about them. If there's any change else to be made, please feel free to request it and I will surely make them with caution (be a change request by the game developer or a native speaker). The changed lines may present some inaccuracies and it's greatly recommended a deeper review of the files changed. Some of the translations I've been made are based on research, on already existing texts under a file and/or on my current knowledge at these languages.
  • About the recovery: Some of the translations have been provided by third-party, specifically from native-speakers, and they've brought up to here without any meaningful change apart from the author of this PR, unless if the changes contain minor and arguable fixes.

⚠️ Additional informations

You may find formattings, such as ", ', ­ and � into some files. Meanings:

  • ": Quotation marks.
  • ': Apostrophe.
  • “: Unicode chart that represents the left double quotation mark.
  • ”: Unicode chart that represents the right double quotation mark.
  • „: Unicode chart that represents the double low-9 quotation mark.
  • ‟: Unicode chart that represents the double high-reversed-9 quotation mark.

Sources

Signed-off-by: Jeiii20 <[email protected]>
Signed-off-by: Jeiii20 <[email protected]>
Signed-off-by: Jeiii20 <[email protected]>
Signed-off-by: Jeiii20 <[email protected]>
@Jeiii20 Jeiii20 changed the title Recovery Pull Requests Recovery Pull Request Oct 16, 2024
Signed-off-by: Jeiii20 <[email protected]>
Signed-off-by: Jeiii20 <[email protected]>
Signed-off-by: Jeiii20 <[email protected]>
Signed-off-by: Jeiii20 <[email protected]>
Signed-off-by: Jeiii20 <[email protected]>
Signed-off-by: Jeiii20 <[email protected]>
Signed-off-by: Jeiii20 <[email protected]>
Line 1153 fixed

Signed-off-by: Jeiii20 <[email protected]>
Signed-off-by: Jeiii20 <[email protected]>
Signed-off-by: Jeiii20 <[email protected]>
Signed-off-by: Jeiii20 <[email protected]>
@Jeiii20
Copy link
Collaborator Author

Jeiii20 commented Oct 17, 2024

Damn, this one may take too long to check, too many details haha. Anyways good luck ^^

Signed-off-by: Jeiii20 <[email protected]>
Signed-off-by: Jeiii20 <[email protected]>
Found even more accurate translations for "horizontal" and "vertical".

Signed-off-by: Jeiii20 <[email protected]>
This is one of another PR's that have been closed after my account deletion; regards a slight update compared to previous PR with more clarity.

Signed-off-by: Jeiii20 <[email protected]>
@Jeiii20
Copy link
Collaborator Author

Jeiii20 commented Oct 19, 2024

Pushed a commit about the README.md, part of a recovery (as of PR #766). It's greatly important a review from the game developer to ensure it can be merged; change requests, feedbacks, inclusions, ommissions or any related stuff are welcome.

"Người" actually means "Person" (singular), while "Mọi Người" is the plural form (People).
Signed-off-by: Jei <[email protected]>
res/values-vi/strings.xml Show resolved Hide resolved
res/values-vi/strings.xml Outdated Show resolved Hide resolved
res/values-vi/strings.xml Outdated Show resolved Hide resolved
res/values-vi/strings.xml Show resolved Hide resolved
res/values-vi/strings.xml Show resolved Hide resolved
res/values-vi/strings.xml Show resolved Hide resolved
res/values-vi/strings.xml Show resolved Hide resolved
res/values-vi/strings.xml Show resolved Hide resolved
@Jeiii20
Copy link
Collaborator Author

Jeiii20 commented Oct 23, 2024

I've marked conversations as resolved, but it's very important to read each one of them, they contain special informations about the untranslated strings.

@Jeiii20 Jeiii20 mentioned this pull request Oct 23, 2024
Signed-off-by: Jei <[email protected]>
"Nhận được" is not adequate here, so changed to "kiếm" that fits much better with the context.
Signed-off-by: Jei <[email protected]>
"có thể" is actually correct grammar for the meaning of "can"
Signed-off-by: Jei <[email protected]>
Fix several errors in grammar: "Diken" is not correct for the meaning of virus, but "Virüs" is.
@Jeiii20
Copy link
Collaborator Author

Jeiii20 commented Oct 25, 2024

@zeynpcna2

If I am not wrong, that was you who provided translation for no_virus in my Discord DM, and it's wrong. According to my research, "diken yok" is not correct grammar, so I changed to "virüs yok". Please check the latest commit above this comment.

Corrected from "mounda" to "modunda"
@Jeiii20
Copy link
Collaborator Author

Jeiii20 commented Oct 25, 2024

Ignore the typo at line 1279, corrected it at this commit: 8ee81f9

@zeynpcna2
Copy link
Collaborator

@zeynpcna2

If I am not wrong, that was you who provided translation for no_virus in my Discord DM, and it's wrong. According to my research, "diken yok" is not correct grammar, so I changed to "virüs yok". Please check the latest commit above this comment.

Turkish players say "thorn/virus" for "hole/Diken", they use the word virus as a disease, we translated it in a way that the players can understand, there were disagreements when 100% translation was made, we adapted it according to the game.

@Jeiii20
Copy link
Collaborator Author

Jeiii20 commented Oct 26, 2024

Oh okay ^^ teşekkür ederim

@Jeiii20
Copy link
Collaborator Author

Jeiii20 commented Oct 26, 2024

Done @zeynpcna2

@grog444 grog444 self-requested a review October 27, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants