Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Cleanup code #10

Open
djenczewski opened this issue Dec 11, 2024 · 0 comments
Open

refactor: Cleanup code #10

djenczewski opened this issue Dec 11, 2024 · 0 comments
Assignees
@djenczewski

Comments

@djenczewski
Copy link
Member

Descripiton

  1. Remove warnings from build process.
  2. Remove Executors.newSingleThreadExecutor() line from StoreFileStreamReader.seek method
  3. Remove commented lines
@djenczewski djenczewski self-assigned this Dec 11, 2024
djenczewski added a commit that referenced this issue Dec 13, 2024
@djenczewski
refactor: Formatting code, suppress warnings, remove typos (#10)
7f08b0d
djenczewski added a commit that referenced this issue Dec 13, 2024
@djenczewski
refactor: remove unused code (#10)
e734462
djenczewski added a commit that referenced this issue Dec 13, 2024
@djenczewski
refactor: Remove duplicated implementation of close method in PrivmxE…
d98d83f 
…ndpoint.java (#10)
djenczewski added a commit that referenced this issue Dec 13, 2024
@djenczewski
refactor: replace Map entry to compatible with Java 8 implementation (#…
a4212ad 
…10)
djenczewski added a commit that referenced this issue Dec 13, 2024
@djenczewski
refactor: Make predefined event types as final (#10)
24fadfe
djenczewski added a commit that referenced this issue Dec 13, 2024
@djenczewski
refactor: make InboxEntryStream.FileInfo fields as final (#10)
6ca41ae
@djenczewski djenczewski mentioned this issue Dec 18, 2024
Merged
djenczewski added a commit that referenced this issue Dec 18, 2024
@djenczewski
refactor: cleanup code (#15)
d2f3158 
* refactor: Formatting code, suppress warnings, remove typos (#10)

* refactor: remove unused code (#10)

* refactor: Remove duplicated implementation of close method in PrivmxEndpoint.java (#10)

* refactor: replace Map entry to compatible with Java 8 implementation (#10)

* refactor: Make predefined event types as final (#10)

* refactor: make InboxEntryStream.FileInfo fields as final (#10)

* refactor: remove unused code from parser and PrivmxEndpoint.java

* refactor: remove unchecked suppressWarning from EventDispatcher.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djenczewski djenczewski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

refs/heads/refactor/cleanup-code simplito/privmx-endpoint-java
1 participant
@djenczewski