Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: cleanup code #15

Merged
merged 8 commits into from
Dec 18, 2024
Merged

refactor: cleanup code #15

merged 8 commits into from
Dec 18, 2024

Conversation

djenczewski
Copy link
Member

Description

Closes #10

All modules

MODIFICATIONS

  1. Remove warnings from build process.
  2. Remove commented lines with unused code
  3. Remove methods incompatible with Java 8
  4. Formatting code

PrivMX Endpoint Extra

MODIFICATIONS

  1. Remove Executors.newSingleThreadExecutor() line from StoreFileStreamReader.seek method
  2. Make predefined event types in EventType class as final.
  3. Make fields of InboxEntryStream.FileInfo class as final.

@djenczewski djenczewski marked this pull request as ready for review December 18, 2024 12:20
@djenczewski djenczewski requested a review from filipg43 December 18, 2024 12:20
@djenczewski djenczewski merged commit d2f3158 into dev Dec 18, 2024
@djenczewski djenczewski mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipg43 filipg43 filipg43 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djenczewski @filipg43