Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: implement container policies #8

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Feat: implement container policies #8

merged 3 commits into from
Dec 2, 2024

Conversation

Drejzer
Copy link
Member

@Drejzer Drejzer commented Nov 29, 2024 •
edited
Loading

closes #7

ADDITIONS

PrivMXEndpointSwiftNative

  • aliases for optionals of policy structs
  • makeOptional() overloads for the above structs

MODIFICATIONS

PrivMXEndpointSwiftNative

  • new parameter in update and create methods for Containers; with a default value of std::nullopt

PrivMXEndpointSwift

  • new optional parameter in update and create methods for Containers, defaulting to nil

@Drejzer Drejzer self-assigned this Nov 29, 2024
@Drejzer Drejzer marked this pull request as ready for review November 29, 2024 14:34
@Drejzer Drejzer merged commit f7bde21 into dev Dec 2, 2024
@Drejzer Drejzer deleted the feat/implement-container-policies branch December 2, 2024 12:54
@Drejzer Drejzer linked an issue Dec 3, 2024 that may be closed by this pull request
[FEAT] Implement Container Policies #7
Closed
@Drejzer Drejzer mentioned this pull request Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipg43 filipg43 filipg43 approved these changes

@bzyglarski bzyglarski Awaiting requested review from bzyglarski

Assignees

@Drejzer Drejzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Implement Container Policies
2 participants
@Drejzer @filipg43