Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Pinecone Library and Bug Fixes #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mmurshed
Copy link

  • Code updated to use new Pinecone library
  • Fixed a bug with get_embedding
  • Replaced a missing model mmarco-mMiniLMv2-L12-H384-v1 from another user

@sinanuozdemir
Copy link
Owner

Thank you for these suggestions! This entire branch is going to be drastically updated with brand new code as we inch closer to the second edition's release date next month. It will include updates to the pinecone client library and I'll be sure to include your bug fixes as well! I'll leave this issue open for now as a reminder to me to integrate.

Thanks again to people like making sure code stays up to date and relevant :)

@sinanuozdemir sinanuozdemir self-assigned this Sep 18, 2024
@mmurshed
Copy link
Author

Can't wait for the 2nd edition to arrive. Already preordered it on Amazon. I will try and fix other notebooks.

@sinanuozdemir
Copy link
Owner

Amazing, I'm so glad :) I hope you were able to leave a rating/review of the first one too! It really helps me out. I would hold off on this branch until I make my big code push for 2E (coming this weekend). It will have dozens of new notebooks so your eyes will be greatly appreciated once I make the changes.

You are always free to suggest changes on the main branch (currently for 1E) :)

@mmurshed
Copy link
Author

Sounds good. I will backport this change to the main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants