-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: clean code in smart_dataframe and smart_datalake #814
Merged
Merged
Changes from 13 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
433ad99
refactor: extract import from file method
gventuri ff945c8
refactor: extract df head methods
gventuri f9ccbba
refactor: move connector config in the relative connector file
gventuri 03634bb
refactor: csv and pandas files are now treated as a connector
gventuri caebf2f
chore: remove verbose getters and setters
gventuri 7b343fb
refactor: remove load and save feature
gventuri d899b66
refactor: create dataframe proxy
gventuri 45097ae
chore: simplify agent
gventuri 935f8ce
chore: simplify datalake
gventuri 945b0fe
refactor: simplify smart datalake
gventuri 8353a41
refactor: centralize context in lakes
gventuri e497d88
refactor: move lake callbacks to dedicate class
gventuri 181689c
fix: load connector before generating cache hex
gventuri e4b2154
fix: only allow direct sql to SQLConnectors
gventuri 480d7bb
fix: check sql connector was not working
gventuri 38886ce
Merge branch 'main' into refactor/clean_code
gventuri fa74b98
fix(connector): update connector validation at the start
ArslanSaleem b6acc29
fix(direct_sql): fix some leftovers
ArslanSaleem ce1e848
Merge branch 'main' into refactor/clean_code
ArslanSaleem c60eb98
fix: merged change revert built-in shadowing
ArslanSaleem e043039
Merge branch 'release/v1.6' into refactor/clean_code
gventuri 8b19c8d
Merge branch 'refactor/clean_code' of https://github.com/gventuri/pan…
gventuri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment for the
head
method's return type should be updated topd.DataFrame
to reflect the actual return type.