Fix bug #395
Open
Fix bug #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarMohamedoi
force-pushed
the
fix-bug
branch
from
db676dc to
a16dc73
Compare
scottenock
reviewed
Dec 12, 2024
Comment on lines
+1
to
+19
| const queryString = require('./index'); | ||
|
|
||
| // Example data that includes null and empty strings | ||
| const params = { | ||
| list: ['item', '', null, 'last'] | ||
| }; | ||
|
|
||
| // Options to reproduce the bug | ||
| const options = { | ||
| arrayFormat: 'comma', | ||
| skipNull: false, | ||
| skipEmptyString: false | ||
| }; | ||
|
|
||
| // Stringify the parameters with the options | ||
| const result = queryString.stringify(params, options); | ||
|
|
||
| // Log the result to console | ||
| console.log(result); // Expected to incorrectly skip null and empty strings based on the bug |
There was a problem hiding this comment.
This example should be in the comment of the PR or expressed via a passing unit test. This file can't be merged into main
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this fix the solution handles null and empty strings properly in the stringify function when using arrayFormat:'comma'. The fix ensures that null values and empty strings are not skipped when the skipNull and skipEmptyString options are set to false. it addresses how the comma array format should properly place commas for those null and empty string values in the output.