Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version for attrs to 17.3.0 #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pblankley
Copy link

Description of change

The current version fails of attrs fails with a aiohttp conflict. See this issue

Manual QA steps

  • Ran tap-facebook using meltano and successfully took live data from my personal facebook ads account into snowflake.

Risks

  • This may break features I'm unaware of that rely specifically on attrs==16.3.0

Rollback steps

  • revert this branch

@cmerrick
Copy link
Contributor

Hi @pblankley, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link
Contributor

You did it @pblankley!

Thank you for signing the Singer Contribution License Agreement.

@pblankley
Copy link
Author

Any thoughts on this??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants