Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "updated prospects stream sync function (#42)" #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 0 additions & 51 deletions .circleci/config.yml

This file was deleted.

3 changes: 0 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
# Changelog

## 1.4.5
* Prospects Stream Fix Pagination [#42](https://github.com/singer-io/tap-pardot/pull/42)

## 1.4.4
* Dependabot update [#41](https://github.com/singer-io/tap-pardot/pull/41)

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

setup(
name="tap-pardot",
version="1.4.5",
version="1.4.4",
description="Singer.io tap for extracting data",
author="Stitch",
url="http://singer.io",
Expand Down
20 changes: 1 addition & 19 deletions tap_pardot/streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ def get_parent_ids(self, parent):

def sync(self):
self.pre_sync()
# pylint: disable=E1102

parent = self.parent_class(
self.client, self.config, self.parent_bookmark, emit=False
)
Expand Down Expand Up @@ -376,24 +376,6 @@ class Prospects(UpdatedAtReplicationStream):

is_dynamic = False

def get_records(self):
offset = 0
params = self.get_params()
while True:
params["offset"] = offset
data = self.client.get(self.endpoint, **params)
records = data["result"]
if not records:
break
offset += 200
yield from records[self.data_key]

def sync(self):
self.pre_sync()
for rec in self.sync_page():
yield rec
self.post_sync()


class Opportunities(NoUpdatedAtSortingStream):
stream_name = "opportunities"
Expand Down