update drop index

singlestore-labs · Mar 4, 2025 · e00f908 · e00f908
1 parent 7953915
commit e00f908
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/drizzle-kit/src/jsonStatements.ts b/drizzle-kit/src/jsonStatements.ts
@@ -2890,7 +2890,7 @@ export const prepareSingleStoreCreateIndexesJson = (
 	tableName: string,
 	schema: string,
 	indexes: Record<string, string>,
-	internal: SingleStoreKitInternals,
+	internal?: SingleStoreKitInternals,
 ): JsonSingleStoreCreateIndexStatement[] => {
 	return Object.values(indexes).map((indexData) => {
 		let type: JsonSingleStoreCreateIndexStatement['type'];

diff --git a/drizzle-kit/src/snapshotsDiffer.ts b/drizzle-kit/src/snapshotsDiffer.ts
@@ -3025,7 +3025,7 @@ export const applySingleStoreSnapshotsDiff = async (
 
 	const jsonCreateIndexesForAllAlteredTables = alteredTables
 		.map((it) => {
-			return prepareCreateIndexesJson(
+			return prepareSingleStoreCreateIndexesJson(
 				it.name,
 				it.schema,
 				it.addedIndexes || {},
@@ -3061,7 +3061,7 @@ export const applySingleStoreSnapshotsDiff = async (
 		);
 
 		jsonCreateIndexesForAllAlteredTables.push(
-			...prepareCreateIndexesJson(it.name, it.schema, createdIndexes || {}),
+			...prepareSingleStoreCreateIndexesJson(it.name, it.schema, createdIndexes || {}),
 		);
 		jsonDropIndexesForAllAlteredTables.push(
 			...prepareDropIndexesJson(it.name, it.schema, droppedIndexes || {}),

diff --git a/drizzle-kit/src/sqlgenerator.ts b/drizzle-kit/src/sqlgenerator.ts
@@ -3701,7 +3701,8 @@ class SingleStoreDropIndexConvertor extends Convertor {
 	}
 
 	convert(statement: JsonDropIndexStatement): string {
-		const { name } = SingleStoreSquasher.unsquashIdx(statement.data);
+		// we have two different index types, but `name` is always the first element in the squashed data
+		const name = statement.data.split(';')[0];
 		return `DROP INDEX \`${name}\` ON \`${statement.tableName}\`;`;
 	}
 }