SHPC New Functionality - Reinstall #674
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Created reinstall file
* Update settings.yml
* reinstall functionality
* Update __init__.py
* Update reinstall.py
* Update reinstall.py
* Update reinstall.py
* cleaning up
* Adding boolean operations to uninstall function, and making the its message user friendly
* Making sure the module to reinstall exists before reinstalling
* fixing user messages
* Modifying uninstall function to keep container.
Also adding flaggers for reinstall (complete and all)
* flagger for complete reinstallation
* fixing bug
* fixing bug (install)
* fixing issue where keep_container is not being recognised
* fixing typo
* fixing bug why complete was not being recognised
* Reinstall all
* Changing tcl back to lmod in settings, rename refactoring and simplying code structure
* removing unnecessary arguements from reinstall
* updating help description
* Attempting to keep container when reinstalling
* removing boolean return values in uninstall function
* adding user message during reinstallation regarding keeping containers
* restoring software to view during reinstallation
* fixing logger messages
* rename
* testing error message
* fixing error message
* checking for invalid recipe
* Tests for Reinstall
* fixing bug
* fixing bug
* adding reinstall tests to test_client.sh
* testing
* testing
* Testing only reinstall functionality before adding it to client test
* fixing issue
* fixing issue
* fixing issue
* fixing issue
* fixing issue
* fixing issue
* fixing issue
* minor refactoring
* updating help message
* adding author
* Implementing Guoying and Matthieu's suggested changes
* Performing precommit locally and removing temp file
* TODO: fix test case ("lmod", "module.lua", "podman", False, False) for test_reinstall_specific_software_version
* fixing linting issue
* reverting
* Update shpc/client/reinstall.py
making comment clearer
Co-authored-by: Matthieu Muffato <[email protected]>
---------
Co-authored-by: Matthieu Muffato <[email protected]>
|
@Ausbeth I think the discussion led to a decision to start with this: #673 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @vsoch, this is the reinstall functionality @muffato talked about. I want to show it to you before making further changes to the
upgrade.