Enable streamlined upgrades with local.py #408
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the k8s deployment experience by making override updates to
settings/local.py
rather than changing the entiresettings/config.py
, like was done in the helm templates referenced in #317. A single container can now be built for use in dev/stg/prd environments and use an updated helm manifest to override values that differ in each env. This also improves the dev & upgrade experience by having local settings not pollute code under source control.Pros/cons of this approach:
config.py
if they want).local.py
everything continues to work.secrets.py
).local.py
vsconfig.py
) requiring several doc updates.config.py
intolocal.py
.Other approaches considered:
config.py
to optionally read every variable from the file or env before falling back to a default/initial value. This approach is also challenging for representing non-string / non-numeric configuration settings (booleans, lists).secret.py
and have them picked up and overrideconfig.py
. This hacky approach convolutes the separation of secrets vs configuration data.