Adds SCSS #21
Closed
Adds SCSS #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k which was correct but I was not expecting that on the test
This version doesn’t rebuild on OS X, Windows XP, 7, or 8. 💂♂️ It also restores the spaces that I deleted.
kennethormandy
referenced
this pull request
in sintaxi/harp
Oct 19, 2013
echaozh missing from contributors list
|
With this branch linked into Harp master, a basic SCSS file renders correctly to CSS. libsass found a binary with no trouble on OSX 10.9 and node |
|
This was merged in and taken care of a while ago:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on @carlosrodriguez’s pull request. Uses the latest version of Node-sass to improve the install on OS X, Windows XP, 7 & 8, and then handles SCSS error messages.
Remaining issues aren’t really related to this:
@warnand@debugis simply output to the console, which is more related to: Handle module’s console output #16The tests need to be updated for the Windows changes, but I didn’t know what to do there.