Remove problems from OriginTag's and OriginInfoValue's admin (#374)

sio2project · May 15, 2024 · 2e63f98 · 2e63f98
1 parent cad153a
commit 2e63f98
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/oioioi/problems/admin.py b/oioioi/problems/admin.py
@@ -296,6 +296,7 @@ class OriginTagLocalizationInline(BaseTagLocalizationInline):
 
 class OriginTagAdmin(BaseTagAdmin):
     inlines = (OriginTagLocalizationInline,)
+    exclude = ['problems']
 
     def formfield_for_manytomany(self, db_field, request, **kwargs):
         _update_queryset_if_problems(db_field, **kwargs)
@@ -336,6 +337,7 @@ class OriginInfoValueLocalizationInline(BaseTagLocalizationInline):
 class OriginInfoValueAdmin(admin.ModelAdmin):
     form = OriginInfoValueForm
     inlines = (OriginInfoValueLocalizationInline,)
+    exclude = ['problems']
 
     def formfield_for_manytomany(self, db_field, request, **kwargs):
         _update_queryset_if_problems(db_field, **kwargs)

diff --git a/oioioi/problems/forms.py b/oioioi/problems/forms.py
@@ -184,10 +184,11 @@ def save(self, commit=True):
         category = self.cleaned_data['category']
         parent_tag = category.parent_tag
         instance.parent_tag = parent_tag
-        problems = self.cleaned_data.get('problems').prefetch_related('origintag_set')
-        for problem in problems:
-            if parent_tag not in problem.origintag_set.all():
-                parent_tag.problems.add(problem)
+        if 'problems' in self.cleaned_data:
+            problems = self.cleaned_data.get('problems').prefetch_related('origintag_set')
+            for problem in problems:
+                if parent_tag not in problem.origintag_set.all():
+                    parent_tag.problems.add(problem)
 
         if commit:
             instance.save()