Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change school_select_form selects to select2 #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Igifigi
Copy link
Contributor

@Igifigi Igifigi commented Aug 21, 2023

A minor change has been made in this PR to make it easier to select a school in the contest registration form. All elements have been changed to elements, which will allow you to select your educational institution more efficiently,

@Igifigi Igifigi requested a review from twalen as a code owner August 21, 2023 17:24
@DietPawel
Copy link
Contributor

I think we should be aware of dependencies in critical system components like registration. In case of offline use CDN might not be available and select2 should be provided via alternative source.

@Igifigi
Copy link
Contributor Author

Igifigi commented Aug 30, 2023

will be fixed soon, for now i set as draft

@Igifigi Igifigi marked this pull request as draft August 30, 2023 18:16
@Igifigi Igifigi marked this pull request as ready for review August 31, 2023 15:38
@Igifigi Igifigi force-pushed the feature-select2 branch 2 times, most recently from ba99163 to 6b360e0 Compare September 2, 2023 07:19
@Igifigi Igifigi marked this pull request as draft September 2, 2023 08:15
@Igifigi Igifigi marked this pull request as ready for review September 3, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants