-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: expected scalar type Half but found BFloat16 #40
base: main
Are you sure you want to change the base?
Conversation
So after all this time, the solution to make pulid work in rtx quadro 6000 was this simple change? |
@moreAImore Yes, this is how the original repo fixed it. Seen here: balazik/ComfyUI-PuLID-Flux@5867d66 Solution #5 didn't work for me when I originally tried it, just like for the other user there. After this change, every flux dev variant I tried worked, including trained ones from civitai. |
Interesting! Quick question, why is this "repo" "enhanced", does it have somethign extra comapred to the other? I thought it was just becuase it supported flux? Does the original support it aswell? thanks |
Also seconde question @drphero , this fix works without having to modity anything in the eva (factory, openai, model.py) files? |
@moreAImore Yes, ComfyUI-PuLID-Flux was made for Flux and was inspired by PuLID_ComfyUI. This enhanced one has some more settings to play around with as mentioned in the readme, but no documentation on what they do. Yes, nothing to do with the eva was changed. I just tried the simplest thing I could find. If you want to just test this PR out, you can do something like this inside the ComfyUI-PuLID-Flux-Enhanced directory: |
I appreciate the instructions, I will save them for a future use. Id rather do the change manually, but I really should adopt more the git method, its more professional. |
While I am waiting for your response: Edit: I fixed it but choosing CUDA from the beginning. If you choose cpu then cuda does not work. |
Sure! You would use If you just want to grab the file, you can click the links in the following order to get to the parent commit and view the files as they were then.
So it's working fine for you now? |
Yes it has seem to be working. |
@drphero for some reason I tried the same fix in another comfy install, it is not working anymore. |
Ok this worked:
|
I mixed this person's code (#52 (comment)) + your fix from here. |
This fixes the "expected scalar type Half but found BFloat16" error for people that have cards that don't support bf16.
Fixes #5 and #15.
Tested on RTX Quadro 6000.