Don't set continue-on-error, it's harmful.

sippy · Jun 16, 2024 · f6d3ad4 · f6d3ad4
1 parent 8bcabfc
commit f6d3ad4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/.github/workflows/rtp.io.yml b/.github/workflows/rtp.io.yml
@@ -17,7 +17,6 @@ jobs:
   build:
     # The type of runner that the job will run on
     runs-on: ${{ matrix.os }}
-    continue-on-error: true
     env:
       COMPILER: ${{ matrix.compiler }}
       BUILD_OS: ${{ matrix.os }}
@@ -82,7 +81,6 @@ jobs:
     runs-on: ubuntu-latest
     container:
       image: sippylabs/rtpproxy:latest
-    continue-on-error: true
     env:
       COMPILER: clang-15
       BUILD_OS: ubuntu-latest

diff --git a/scripts/build/do_build.sh b/scripts/build/do_build.sh
@@ -15,7 +15,7 @@ then
 fi
 
 MAKE_ENV="CC_EXTRA_OPTS=${CC_EXTRA_OPTS:-"-Werror"} FASTER=1 NICER=0"
-MAKE_CMD="${MAKE_ENV} make"
+MAKE_CMD="env ${MAKE_ENV} make"
 
 if [ ! -z "${ONE_MODULE}" ]
 then