Skip to content

Commit

Permalink
MT#55283 fix UDP hardware checksumming
Browse files Browse the repository at this point in the history
skb->csum and skb->csum_{start,offset} are actually in a union.

Fix copy/pasto in IPv4 code path.

Change-Id: I84c498f191d1fc22b987da357e068b9e2f615297
  • Loading branch information
rfuchs committed Apr 11, 2024
1 parent 28e9079 commit e0efaf7
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions kernel-module/xt_RTPENGINE.c
Original file line number Diff line number Diff line change
Expand Up @@ -3937,10 +3937,7 @@ static int send_proxy_packet4(struct sk_buff *skb, struct re_address *src, struc
goto drop;
skb->dev = skb_dst(skb)->dev;

skb->csum_start = skb_transport_header(skb) - skb->head;
skb->csum_offset = offsetof(struct udphdr, check);

if (skb->dev->features & (NETIF_F_HW_CSUM | NETIF_F_IPV6_CSUM)) {
if (skb->dev->features & (NETIF_F_HW_CSUM | NETIF_F_IP_CSUM)) {
skb->ip_summed = CHECKSUM_PARTIAL;
skb->csum = 0;
udp4_hwcsum(skb, ih->saddr, ih->daddr);
Expand Down Expand Up @@ -4037,7 +4034,6 @@ static int send_proxy_packet6(struct sk_buff *skb, struct re_address *src, struc

if (skb->dev->features & (NETIF_F_HW_CSUM | NETIF_F_IPV6_CSUM)) {
skb->ip_summed = CHECKSUM_PARTIAL;
skb->csum = 0;
uh->check = ~csum_ipv6_magic(&ih->saddr, &ih->daddr, datalen, IPPROTO_UDP, 0);
}
else {
Expand Down

0 comments on commit e0efaf7

Please sign in to comment.