Skip to content

Commit

Permalink
MT#61140 Fix Coverity Scan defect (to_tag_flag)
Browse files Browse the repository at this point in the history
Add `break` statement. Fixes:

*** CID 1600019:  Control flow issues  (MISSING_BREAK)
/daemon/call_interfaces.c: 1162 in call_ng_flags_flags()
1156                            out->strip_extmap = 1;
1157                            break;
1158                    case CSH_LOOKUP("symmetric-codecs"):
1159                            ilog(LOG_INFO, "Ignoring obsolete flag `symmetric-codecs`");
1160                            break;
1161                    case CSH_LOOKUP("to-tag"):
>>>     CID 1600019:  Control flow issues  (MISSING_BREAK)
>>>     The case for value "155" is not terminated by a "break" statement.
1162                    case CSH_LOOKUP("to_tag"):
1163                            /* including the To tag in the delete message allows to be more selective
1164                             * about monologues within a dialog to be torn down. */
1165                            out->to_tag_flag = 1;
1166                    case CSH_LOOKUP("trickle-ICE"):
1167                    case CSH_LOOKUP("trickle-ice"):

Change-Id: I0195341ec70ea623ea7fece3782cfdc030ee4eaf
(cherry picked from commit ac4a1ba)
(cherry picked from commit 442884c)
  • Loading branch information
zenichev committed Oct 2, 2024
1 parent 028c62e commit ea6fdcb
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions daemon/call_interfaces.c
Original file line number Diff line number Diff line change
Expand Up @@ -1194,6 +1194,7 @@ void call_ng_flags_flags(sdp_ng_flags *out, str *s, helper_arg dummy) {
/* including the “To” tag in the “delete” message allows to be more selective
* about monologues within a dialog to be torn down. */
out->to_tag_flag = 1;
break;
case CSH_LOOKUP("trickle-ICE"):
case CSH_LOOKUP("trickle-ice"):
out->trickle_ice = 1;
Expand Down

0 comments on commit ea6fdcb

Please sign in to comment.