Skip to content

Commit

Permalink
MT#60476 obsolete last_in_sdp(_parsed)
Browse files Browse the repository at this point in the history
Not needed any more. All strings reside in the call's memory arena, and
SDP rewriting isn't a thing any more.

Change-Id: I594b85fe26f44fa25312eb97fb65de238fc18920
  • Loading branch information
rfuchs committed Oct 2, 2024
1 parent 7125f0f commit ec500bd
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
1 change: 0 additions & 1 deletion daemon/call.c
Original file line number Diff line number Diff line change
Expand Up @@ -4046,7 +4046,6 @@ void __monologue_free(struct call_monologue *m) {
sdp_orig_free(m->session_sdp_orig);
if (m->session_last_sdp_orig)
sdp_orig_free(m->session_last_sdp_orig);
sdp_sessions_clear(&m->last_in_sdp_parsed);
t_queue_clear_full(&m->generic_attributes, sdp_attr_free);
t_queue_clear_full(&m->all_attributes, sdp_attr_free);
sdp_streams_clear(&m->last_in_sdp_streams);
Expand Down
6 changes: 0 additions & 6 deletions daemon/call_interfaces.c
Original file line number Diff line number Diff line change
Expand Up @@ -2104,12 +2104,6 @@ static enum load_limit_reasons call_offer_session_limit(void) {


void save_last_sdp(struct call_monologue *ml, str *sdp, sdp_sessions_q *parsed, sdp_streams_q *streams) {
ml->last_in_sdp = *sdp;

sdp_sessions_clear(&ml->last_in_sdp_parsed);
ml->last_in_sdp_parsed = *parsed;
t_queue_init(parsed);

sdp_streams_clear(&ml->last_in_sdp_streams);
ml->last_in_sdp_streams = *streams;
t_queue_init(streams);
Expand Down
2 changes: 0 additions & 2 deletions include/call.h
Original file line number Diff line number Diff line change
Expand Up @@ -591,8 +591,6 @@ struct call_monologue {
struct media_player *player;
struct media_player *rec_player;
struct session_bandwidth sdp_session_bandwidth;
str last_in_sdp;
sdp_sessions_q last_in_sdp_parsed; /* last parsed `sdp_session` */
sdp_streams_q last_in_sdp_streams; /* last parsed `stream_params` */
GString *last_out_sdp;

Expand Down

0 comments on commit ec500bd

Please sign in to comment.