Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Fix misspelled reject-ICE offer attribute #1907

Closed
wants to merge 1 commit into from

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jan 24, 2025

No description provided.

@rfuchs
Copy link
Member

rfuchs commented Jan 24, 2025

Both are actually accepted by the parser. In fact any space is translated to a hyphen when parsing.

@orgads
Copy link
Contributor Author

orgads commented Jan 24, 2025

Then why are there duplicate cases for other flags? A few examples:

  case CSH_LOOKUP("address family"):
  case CSH_LOOKUP("address-family"):
  // ...
  case CSH_LOOKUP("call-id"):
  case CSH_LOOKUP("call-ID"):
  case CSH_LOOKUP("call id"):
  case CSH_LOOKUP("call ID"):
  // ...

@rfuchs
Copy link
Member

rfuchs commented Jan 24, 2025

Then why are there duplicate cases for other flags? A few examples:

These are in the main parsing entry point, which doesn't have a call to str_hyphenate. Should probably streamline these and avoid str_hyphenate where possible and instead list non-hyphenated alternatives explicitly.

@orgads
Copy link
Contributor Author

orgads commented Jan 24, 2025

I see, thanks for the clarification.

@orgads orgads closed this Jan 24, 2025
@orgads orgads deleted the doc-reject-ice branch January 26, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants