-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rest api refactor #590
Rest api refactor #590
Conversation
@JohannesLichtenberger I kept the Also I think for Creation, I couldn't find many common stuff among XML and JSON that can be refactored into abstract class. Before proceeding further, I wanted to check if this was ok with you. Would it be okay to put some common logic in |
@redwanulsourav I would delete I'd proceed like this as well for the other classes (interface + abstract class + implementations). |
@JohannesLichtenberger I think I understood what you have mentioned. I just wanted to confirm it again. Would it be like this: |
Yes :-) |
I think it's probably the cleanest solution, but of course I don't want to dictate this :-) I hope it makes sense, so I'm of course up for discussions if you think another approach would be better. |
I think |
Refactored the code for database and resource creation. #523