Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-sisimai compatibility 7e89 #311

Merged
merged 11 commits into from
Oct 9, 2024
Merged

Conversation

azumakuniyuki
Copy link
Member

@azumakuniyuki azumakuniyuki commented Oct 9, 2024

  • Sisimai::SMTP::Error has been renamed to Sisimai::SMTP::Failure and the following methods implemented:
    • is_temporary()
    • is_hardbounce()
    • is_softbounce()
    • soft_or_hard() has been removed
  • Changes in Sisimai::Rhost
    • get() method has been renamed to find()
    • Fix bug in code to check the domain part of an email address as a remote hostname
    • Add ['4.4.4', 0, 0, 'hosted tenant which has no mail-enabled subscriptions' in Sisimai::Rhost::Microsoft
  • Code improvement and bug fix at Sisimai::Lhost::Exim
    • Remove needless condition for getting error messages
    • Rewrite code for getting an SMTP reply code and a delivery status code
  • Add a new error message pattern in Sisimai::Reason::BadReputation

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 95.49550% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.00%. Comparing base (cbf9ebf) to head (90485fc).
Report is 12 commits behind head on 5-stable.

Files with missing lines Patch % Lines
lib/sisimai/reason.rb 86.20% 4 Missing ⚠️
lib/sisimai/lhost/exim.rb 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           5-stable     #311   +/-   ##
=========================================
  Coverage     94.99%   95.00%           
=========================================
  Files           135      135           
  Lines          6798     6783   -15     
=========================================
- Hits           6458     6444   -14     
+ Misses          340      339    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azumakuniyuki azumakuniyuki merged commit 03ab0da into 5-stable Oct 9, 2024
7 checks passed
azumakuniyuki added a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant