Prefer html snapshots when internet archive integration is disabled #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cy7sh
force-pushed
the
prefer-html-snapshot
branch
from
153ecd9
to
d932b62
Compare
|
Addresses #867 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the timestamp always links to the Internet Archive snapshot even when Internet Archive integration is disabled. I believe it generates a fallback URL that's close to the timestamp which does work well but I think it's confusing. When integration is disabled and there is a local HTML snapshot available, it makes sense to prefer that over the fallback wayback machine URL. Also, there's no other way to change this behavior AFAIK.
I was debating whether there should be a separate setting to change what clicking on the timestamp does, but I think people would expect that disabling Internet Archive integration shouldn't still link to it.