Skip to content

Commit

Permalink
🌱 Reorganize jest dependencies, no workspace node_modules (konveyor…
Browse files Browse the repository at this point in the history
…#1350)

As a side-effect of having all of the jest dependencies only in the
`client/` workspace, a `client/node_modules` folder was being created
during npm install. While this is ok for online upstream builds, the
downstream offline builds were breaking due to extra layer of
complexity.

Arranging dependencies across projects to prefer a single
`node_modules/` folder is highly preferred.

Signed-off-by: Scott J Dickerson <[email protected]>
  • Loading branch information
sjd78 authored Sep 12, 2023
1 parent c44218d commit 5c991f2
Show file tree
Hide file tree
Showing 4 changed files with 1,888 additions and 3,266 deletions.
9 changes: 1 addition & 8 deletions client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"@dnd-kit/sortable": "^7.0.2",
"@hookform/resolvers": "^2.9.11",
"@hot-loader/react-dom": "^17.0.2",
"@konveyor-ui/common": "*",
"@migtools/lib-ui": "^9.0.3",
"@patternfly/patternfly": "^5.0.2",
"@patternfly/react-charts": "^7.1.0",
Expand All @@ -35,7 +34,6 @@
"@react-keycloak/web": "^3.4.0",
"@tanstack/react-query": "^4.22.0",
"@tanstack/react-query-devtools": "^4.22.0",
"@types/ejs": "^3.1.0",
"axios": "^0.21.2",
"dayjs": "^1.11.7",
"ejs": "^3.1.7",
Expand Down Expand Up @@ -67,8 +65,8 @@
"@testing-library/react-hooks": "^8.0.1",
"@testing-library/user-event": "^14.4.3",
"@types/dotenv-webpack": "^7.0.3",
"@types/ejs": "^3.1.0",
"@types/file-saver": "^2.0.2",
"@types/jest": "^29.5.3",
"@types/js-yaml": "^4.0.5",
"@types/react": "^17.0.0",
"@types/react-dom": "^17.0.0",
Expand All @@ -87,10 +85,6 @@
"fork-ts-checker-webpack-plugin": "^8.0.0",
"html-webpack-plugin": "^5.5.0",
"i18next-parser": "^0.13.0",
"jest": "^29.6.2",
"jest-environment-jsdom": "^29.6.2",
"jest-resolve": "^27.4.6",
"jest-watch-typeahead": "^1.0.0",
"mini-css-extract-plugin": "^2.5.2",
"monaco-editor-webpack-plugin": "^7.0.1",
"msw": "^1.2.3",
Expand All @@ -102,7 +96,6 @@
"style-loader": "^3.3.1",
"svg-url-loader": "^7.1.1",
"terser-webpack-plugin": "^5.3.0",
"ts-jest": "^29.1.1",
"ts-loader": "^9.4.1",
"tsconfig-paths-webpack-plugin": "^4.0.0",
"url-loader": "^4.1.1",
Expand Down
2 changes: 1 addition & 1 deletion client/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"../node_modules/@patternfly/react-core/dist/styles/assets/*"
]
},
"typeRoots": ["types/", "node_modules/@types"],
"typeRoots": ["types/", "node_modules/@types", "../node_modules/@types"],

"target": "es2020",
"module": "es2020",
Expand Down
Loading

0 comments on commit 5c991f2

Please sign in to comment.