Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a custom scrollbar on all the pages . #507

Closed
wants to merge 1 commit into from

Conversation

meetarora10
Copy link
Contributor

Description

I have added a custom scrollbar to all the pages that matches with the UI of the website.

Fixes: #488

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Screenshot (859)
Screenshot (860)

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@aditya-bhaumik
Copy link
Collaborator

aditya-bhaumik commented Jul 27, 2024

@meetarora10 but this design is already there in all the pages as all the pages are linked with the styles.css i thouht you were changing the scrollbar why did you removed the code from the css and added it individually in all the other pages wouldn't it make the code bigger in other pages and keeping it in styles ensured that the scrollbar is there in any new page added to the website later right

@meetarora10
Copy link
Contributor Author

meetarora10 commented Jul 27, 2024

@aditya-bhaumik yes it was present but scrollbar was not visible in the website. So I added in individual files , trying to make it visible in all the pages in the website.

@meetarora10
Copy link
Contributor Author

If you say I will change the styling of the scrollbar @aditya-bhaumik

@aditya-bhaumik
Copy link
Collaborator

aditya-bhaumik commented Jul 27, 2024

@meetarora10 it is visible as i checked it in all pages you can try changing the scrollbar to some better design but dont remove it from the styles.css and also remove the extra code you put in html files

i am closing this pr you can create another pr with the changes

Make a scrollbar which will look good with the projects color theme

@meetarora10
Copy link
Contributor Author

Ok @aditya-bhaumik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡[Feature]: Add a custom scrollbar which matches with UI of website .
2 participants