-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #510 #514
Issue #510 #514
Conversation
Used session storage to enable the loader only once per session, ie avoid loader when the user naviagtes to the home page from other side pages Accoridngly adjusted the display of back to top button, nav menu and the warning modal ensuring that the set time out function on these elements is not executed on instances other than initial load
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
@Jasleen1210 test.mp4 |
@sk66641 Ive tried re-running on multiple browsers but im not facing the same issue, can you tell me more about when did you encounter it and what was the error in the console at that time? |
@Jasleen1210 i think it is not running after we first use the simulation then go back to the main screen then again try to run the simulation |
@aditya-bhaumik could you tell me what you see in the console at the time? and confirm the browser you use? i still havent encountered the issue and i can't find any logic issue in the code that could be causing the same either |
test.mp4 |
@Jasleen1210 have fixed the problem ?? also there conflicts in the pr now fix that also |
@aditya-bhaumik resolved the conflicts but i haven't been able to get rid of the issue, the code stops at the line where chatbot display is hidden and if i change the positioning of that line more issues are created |
@Jasleen1210 i am closing this pull request as for the moment you can work on your other issues when you solve this problem you can raise another pull request |
Description
Used session storage to enable the loader only once per session, i.e. avoid loader when the user navigates to the home page from other side pages
Accordingly adjusted the display of back to top button, nav menu and the warning modal ensuring that the set time out function on these elements is not executed on instances other than initial load
Fixes: #510
Type of change
Checklist:
ATTACH SCREEN-SHOTS / DEPLOYMENT LINK