Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #510 #514

Closed
wants to merge 2 commits into from
Closed

Issue #510 #514

wants to merge 2 commits into from

Conversation

Jasleen1210
Copy link
Contributor

Description

Used session storage to enable the loader only once per session, i.e. avoid loader when the user navigates to the home page from other side pages

Accordingly adjusted the display of back to top button, nav menu and the warning modal ensuring that the set time out function on these elements is not executed on instances other than initial load

Fixes: #510

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Used session storage to enable the loader only once per session, ie avoid loader when the user naviagtes to the home page from other side pages
Accoridngly adjusted the display of back to top button, nav menu and the warning modal ensuring that the set time out function on these elements is not executed on instances other than initial load
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@sk66641
Copy link
Owner

sk66641 commented Jul 28, 2024

@Jasleen1210
sometimes simulation doesn't work after successful submission

test.mp4

@Jasleen1210
Copy link
Contributor Author

@sk66641 Ive tried re-running on multiple browsers but im not facing the same issue, can you tell me more about when did you encounter it and what was the error in the console at that time?

@aditya-bhaumik
Copy link
Collaborator

@Jasleen1210 i think it is not running after we first use the simulation then go back to the main screen then again try to run the simulation

@Jasleen1210
Copy link
Contributor Author

@aditya-bhaumik could you tell me what you see in the console at the time? and confirm the browser you use? i still havent encountered the issue and i can't find any logic issue in the code that could be causing the same either

@sk66641
Copy link
Owner

sk66641 commented Jul 30, 2024

@Jasleen1210

test.mp4

@aditya-bhaumik
Copy link
Collaborator

@Jasleen1210 have fixed the problem ?? also there conflicts in the pr now fix that also

@Jasleen1210
Copy link
Contributor Author

@aditya-bhaumik resolved the conflicts but i haven't been able to get rid of the issue, the code stops at the line where chatbot display is hidden and if i change the positioning of that line more issues are created

@aditya-bhaumik
Copy link
Collaborator

@Jasleen1210 i am closing this pull request as for the moment you can work on your other issues when you solve this problem you can raise another pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Loader: once per session
3 participants