Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different theme slider #521

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Different theme slider #521

merged 2 commits into from
Jul 29, 2024

Conversation

Jasleen1210
Copy link
Contributor

Description

I have removed the code for the old theme toggle and added the new one in styles.css file
Replaced the toggle in privacy and terms pages, however i did not add the toggle to the pages where it was absent because it might've been with another existing open issue, but let me know if the same is supposed to be covered under my issue only

Fixes: #511

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Adjusted slider on 404 page, deleted existing styes, added styles.css, edited the js file to recognize new toggle, solved overwriting issues
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Jasleen1210 Jasleen1210 changed the title Slider Different theme slider Jul 28, 2024
@sk66641
Copy link
Owner

sk66641 commented Jul 29, 2024

I have removed the code for the old theme toggle and added the new one in styles.css file Replaced the toggle in privacy and terms pages, however i did not add the toggle to the pages where it was absent because it might've been with another existing open issue, but let me know if the same is supposed to be covered under my issue only

It's fine. Actually, there's already an issue #508 regarding adding mode toggler in the pages where it's absent

@sk66641 sk66641 merged commit 3cdcc0b into sk66641:main Jul 29, 2024
2 checks passed
@sk66641 sk66641 added enhancement New feature or request gssoc This Contribution is under GSSOC'24 level1 bug Something isn't working level2 and removed level1 labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request gssoc This Contribution is under GSSOC'24 level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Different theme slider
2 participants