Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset Modals and Notifications #524

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Conversation

Jasleen1210
Copy link
Contributor

Description

Added modals for both saving and loading presets,
Edited notification popups such that they display the message passed in the function as the text of the notif
Added fail/success notifications whereever necessary in the preset process

Fixes:
Issue #516
Issue #518
[I made the changes in the same branch because i forgot i made two separate issues for it, if you could adjust the level accordingly ill be extremely grateful, thankyou!]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • [x I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

image
image
image

Made modals for both saving and loading preset prompts
issue #516
Added success and failed notifications by editing the existing function to take message as input
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@aditya-bhaumik
Copy link
Collaborator

@Jasleen1210 i dont know if i give both level 1 and level 2 in this it will be counted or not you can create a empty pr i will add the level 1 there

@aditya-bhaumik aditya-bhaumik added gssoc This Contribution is under GSSOC'24 level2 labels Jul 30, 2024
@Jasleen1210
Copy link
Contributor Author

@aditya-bhaumik done

@aditya-bhaumik aditya-bhaumik merged commit 2d9e7cc into sk66641:main Jul 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc This Contribution is under GSSOC'24 level2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants