Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to top button #533

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Back to top button #533

merged 1 commit into from
Jul 31, 2024

Conversation

Jasleen1210
Copy link
Contributor

@Jasleen1210 Jasleen1210 commented Jul 30, 2024

Description

Updated the backtotop js file completely and added code and listeners that do not cause issues in the console and get executed smoothly without fail tested on all pages and ensured that button is hidden during loading and simulation
Added function that is disabled (hidden) on zero scroll on all pages
Removed pointless css added in each of the side pages for a minor thing (bottom spacing) so improved it by adding a separate div name on main page (hence the number of reduced lines of code) and also loading time decreased after these changes considerably
Fixes: #515
kindly consider updating level thank youu

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Pointless css was added in each of the side pages for a minor thing (bottom spacing) so improved it by adding a separate div name on main page
Updates the backtotop js file completely and added code to and listeners that do not cause issues in the console and get executed smoothly without fail
tested on all pages and ensured that button is hidden during loading and simulation
Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@sk66641 sk66641 merged commit c6654c5 into sk66641:main Jul 31, 2024
2 checks passed
@sk66641 sk66641 added enhancement New feature or request gssoc This Contribution is under GSSOC'24 level3 labels Jul 31, 2024
@Jasleen1210 Jasleen1210 deleted the chat branch August 5, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc This Contribution is under GSSOC'24 level3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡[Feature]: Back to top button
2 participants