Support Boost 1.87 #368
Merged
Support Boost 1.87 #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Homebrew deleted 1.86, so a bump was needed.
Boost.Asio made this rename ages ago, but kept the old name as an alias. Boost 1.87 drops the alias though, breaking all the spead2 code. Apart from switching the use of the Boost type, also rename classes (io_service_ref) and methods (get_io_service) to match, keeping deprecated aliases so that spead2 users have a migration path.
io_context::post and ip::address[_v4/6]::from_string have been removed and replaced by boost::asio::post and ip::make_address[_v4/6], and io_context::work has been replaced by executor_work_guard.
The code was already using features introduced by 1.70, but the meson.build indicated 1.69 as the minimum. Nobody has complained, so I'm just bumping the minimum to 1.70.
One function wasn't actually used, so delete it.
The minimum version that works is 1.70, so this code is no longer useful.
This was breaking cibuildwheel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boost 1.87 dropped a lot of deprecated functionality that spead2 was still using. Modernise to use the new forms, which seem to have been available since at least Boost 1.70, which is now the minimum.