Use the markup helper when rendering previews #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contribution previews should be rendered exactly the same as the actual contribution after saving will be. Thus, we need to use the same markup helper for that.
|
🔨 |
|
@s2gatev, не мога да разбера това съдийско чукче одобрение или неодобрение изразява :) |
|
Одобрение. @skanev |
|
Ping @skanev |
|
Теста не ми харесва, ама не мога да измисля нещо по-умно. |
skanev
added a commit
that referenced
this pull request
Jan 29, 2014
Use the markup helper when rendering previews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Прегледа на contribution трябва да изглежда по абсолютно същия начин, по който би изглеждал въпросният текст, след като се съхрани и рендерира. За тази цел е добра идея да ползваме същия
markuphelper.Подсетих се за това от #114 и #115.