PR for graduate project #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and string in code
…balance from user
previously, if query returned more than one row, this method returned last one
…pdate previously it was Order in both cases. first change is for efficiency, second for clarity (what fields would be updated)
schetininl
reviewed
Jul 5, 2022
There was a problem hiding this comment.
Проект в целом сделан хорошо. Есть один момент. В модуле app намешано много всего. И транспортный уровень (http) и бизнес логика и мидлвары. Это стоит разбить на разные пакеты. Причем бизнес логика не должна ничего знать о хендлерах и прочих вещах, только о доменных моделях. Так проект станет более гибким. Вдруг понадобиться в будушем с http перейти на grpc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Выпускной проект курса Go-разработчик от Яндекс.Практикума. ТЗ описано в SPECIFICATION.md
For English-speaking readers: this pull request contains my work on graduate project for "Go developer" course from Yandex.Practicum. Specification to which it must conform is given in SPECIFICATION.md in Russian language.