Úpravy pro Obrok (přihlašování skupin) #1099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-stanek
temporarily deployed
to
srs-obrok.skauting.cz
GitHub Actions
Inactive
jan-stanek
force-pushed
the
obrok/master
branch
from
96d900b to
757dfa0
Compare
jan-stanek
temporarily deployed
to
srs-obrok.skauting.cz
GitHub Actions
Inactive
Co-authored-by: Jan Havelka <[email protected]>
jan-stanek
temporarily deployed
to
srs-obrok.skauting.cz
GitHub Actions
Inactive
Co-authored-by: Jan Havelka <[email protected]>
jan-stanek
temporarily deployed
to
srs-obrok.skauting.cz
GitHub Actions
Inactive
jan-stanek
commented
Nov 23, 2023
| use App\Model\Group\Status; | ||
| use Doctrine\Common\Collections\Collection; | ||
|
|
||
| class StatusUpdatedEvent |
There was a problem hiding this comment.
tahle akce je u účastníků při změně kategorie (kategorie říká, jaké role mají právo si registrovat programy v ní), při změně stavu by měla akce vypadat jinak
There was a problem hiding this comment.
spíš by tu měla zůstat jen GroupUpdated, ve které se bude řešit i případ, že se mění stav skupiny, ale u jednotlivých stavů se nic měnit nebude
jan-stanek
commented
Nov 23, 2023
app/Model/Group/Group.php
Outdated
| * Entita uživatele. | ||
| */ | ||
| #[ORM\Entity] | ||
| #[ORM\Table(name: 'group')] |
There was a problem hiding this comment.
porblém s klíčovým slovem group
jan-stanek
commented
Nov 23, 2023
| /** | ||
| * Třída spravující statusy programových bloků. | ||
| */ | ||
| class StatusRepository extends AbstractRepository |
There was a problem hiding this comment.
statusy bych nechal napevno, jak jsme se bavili
jan-stanek
commented
Nov 23, 2023
| $status = $command->getStatus(); | ||
|
|
||
|
|
||
| $this->statusRepository->remove($status); |
There was a problem hiding this comment.
co by se stalo se skupinami, které ten status používají?
jan-stanek
commented
Nov 23, 2023
| $this->programApplications = new ArrayCollection(); | ||
| $this->lecturersBlocks = new ArrayCollection(); | ||
| $this->notRegisteredMandatoryBlocks = new ArrayCollection(); | ||
| $this->customInputValues = new ArrayCollection(); |
There was a problem hiding this comment.
neexistující prosím pryč
Co-authored-by: Jan Staněk <[email protected]>
jan-stanek
temporarily deployed
to
srs-obrok.skauting.cz
GitHub Actions
Inactive
* cumulative commit * afetr phpcbf app * cumulative commit * afetr phpcbf app * phpstan correction --------- Co-authored-by: Jan Havelka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.