Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby and support Rails v8 #111

Merged
Merged
4 changes: 2 additions & 2 deletions .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: 3.3.5
ruby-version: 3.3.7
- name: rubocop
uses: reviewdog/action-rubocop@v2
with:
Expand All @@ -22,7 +22,7 @@ jobs:
- uses: actions/checkout@v4
- uses: ruby/setup-ruby@v1
with:
ruby-version: 3.3.5
ruby-version: 3.3.7
- name: reek
uses: reviewdog/action-reek@v1
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
matrix:
os: [ubuntu-latest]
# Due to https://github.com/actions/runner/issues/849, we have to use quotes for '3.0'
ruby: ["3.2.5", "3.3.5", truffleruby]
ruby: ["3.2.6", "3.3.7", truffleruby]
db: ["mariadb", "mysql", "pg"]
runs-on: ${{ matrix.os }}
services:
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:
bin/test

- name: Upload coverage
if: ${{ matrix.db == 'pg' && matrix.ruby == '3.2.5' }}
if: ${{ matrix.db == 'pg' && matrix.ruby == '3.2.6' }}
uses: actions/upload-artifact@v4
with:
name: review.txt
Expand Down
3 changes: 3 additions & 0 deletions .reek.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@ directories:
"test":
UtilityFunction:
enabled: false

exclude_paths:
- lib/generators/deploy_pin/**/templates/**/*.rb
2 changes: 2 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ inherit_from: .rubocop_todo.yml
require: rubocop-minitest

AllCops:
Exclude:
- lib/generators/deploy_pin/**/templates/**/*.rb
NewCops: disable
TargetRubyVersion: 3.1

Expand Down
14 changes: 3 additions & 11 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2024-10-17 14:41:35 UTC using RuboCop version 1.66.1.
# on 2024-12-31 14:12:31 UTC using RuboCop version 1.69.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand All @@ -23,12 +23,6 @@ Lint/Void:
Metrics/AbcSize:
Max: 20

# Offense count: 2
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
# AllowedMethods: refine
Metrics/BlockLength:
Max: 29

# Offense count: 1
# Configuration parameters: CountComments, CountAsOne.
Metrics/ClassLength:
Expand Down Expand Up @@ -57,7 +51,7 @@ Security/Eval:
Exclude:
- 'lib/deploy_pin/task.rb'

# Offense count: 13
# Offense count: 11
# Configuration parameters: AllowedConstants.
Style/Documentation:
Exclude:
Expand All @@ -73,9 +67,7 @@ Style/Documentation:
- 'lib/deploy_pin/task.rb'
- 'lib/deploy_pin/task_criteria.rb'
- 'lib/generators/deploy_pin/install/install_generator.rb'
- 'lib/generators/deploy_pin/install/templates/create_deploy_pins.rb'
- 'lib/generators/deploy_pin/task/task_generator.rb'
- 'lib/generators/deploy_pin/upgrade/templates/upgrade_deploy_pins.rb'

# Offense count: 2
Style/MixinUsage:
Expand All @@ -85,7 +77,7 @@ Style/MixinUsage:

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
# URISchemes: http, https
Layout/LineLength:
Max: 121
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.3.5
3.3.7
Loading
Loading