Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23029] Use remote icon implementation #172

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

MichaelReyes
Copy link
Collaborator

Pull Request (PR) Checklist

Thank you for your contribution! Please confirm that you've checked all the boxes below before submitting your PR. Use [x] to check a box, e.g., [x], and make sure there's no space around the brackets.

PR Context

  • Type: (Bug Fix / Feature / Refactor / Regression Fix) Choose one and delete the rest.
  • Issue Link: Redmine Issue
  • Risk Factor: (Low / Medium / High) - Provide a brief explanation of the risk.

Changes

Describe your changes in detail, highlighting the problem it solves or the feature it adds.

  • [TripGov5] update BaseApplication to initialize DeviceInfo singleton on app start
  • [TripKitUI] update createStopMarkerOptions and add an extension for generating marker options with remote checking and fetching
  • [TripKitUI] add DeviceInfo to set density dpi name once initialized from app start
  • [TripKitUI] add MarkerOptionsTarget for picasso target specifically for MarkerOptions loading
  • [TripKitUI] add RemoteMarkerIconFetcher to handle loading of marker icon using picasso and setting it on the MarkerOptions asynchronously
  • [TripKitUI] update StopMarkerUtils and generating of marker icon url from modeInfo using static endpoint
  • [TripKitUI] update StopPOILocation and call createStopMarkerOptions and pass picasso instance
  • [TripKitUI] update createStopMarkerOptions to only load marker from RemoteMarkerIconFetcher
  • [TripKitUI] update RemoteMarkerIconFetcher update circle bitmap with aspect ratio checking to properly render the bitmap inside the circle bitmap and add a white border. Also add error handling to load local resource.
  • [TripKitUI] update StopMarkerUtils and add function for getting localIconName with density from modeInfo

Checklist for Reviewers

Documentation and Code Quality

  • KDocs Documentation: Are all changes, new functionalities, and classes documented with KDocs?
  • Architectural Patterns: Is there consistent and proper use of architectural patterns (e.g., MVVM, MVP)?

Testing and Reliability

  • Unit Testing: Are there unit tests for all new functionalities and classes?
  • Emulator and Real Device Testing: Has the application been tested on both emulators and real devices to ensure compatibility?

Error Handling and Logging

  • Error Handling: Are errors and exceptions caught and handled gracefully, ensuring the app remains stable?
  • Logging: Is there proper logging in place for critical errors and information, aiding in debugging and monitoring?

Testing Procedure

If applicable, provide steps or commands for testing your changes. This can help reviewers and testers.

Work-in-Progress (WIP)

List any remaining work or areas that need additional focus. This section can be updated as the work progresses.

  • [ ]
  • [ ]

Remember to keep this template updated based on the feedback and evolving project standards.

- [TripGov5] update BaseApplication to initialize DeviceInfo singleton on app start
- [TripKitUI] update createStopMarkerOptions and add an extension for generating marker options with remote checking and fetching
- [TripKitUI] add DeviceInfo to set density dpi name once initialized from app start
- [TripKitUI] add MarkerOptionsTarget for picasso target specifically for MarkerOptions loading
- [TripKitUI] add RemoteMarkerIconFetcher to handle loading of marker icon using picasso and setting it on the MarkerOptions asynchronously
- [TripKitUI] update StopMarkerUtils and generating of marker icon url from modeInfo using static endpoint
- [TripKitUI] update StopPOILocation and call createStopMarkerOptions and pass picasso instance
- [TripKitUI] update createStopMarkerOptions to only load marker from RemoteMarkerIconFetcher
- [TripKitUI] update RemoteMarkerIconFetcher update circle bitmap with aspect ratio checking to properly render the bitmap inside the circle bitmap and add a white border. Also add error handling to load local resource.
- [TripKitUI] update StopMarkerUtils and add function for getting localIconName with density from modeInfo
Copy link

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

@MichaelReyes MichaelReyes merged commit cc00038 into develop Jan 20, 2025
1 check passed
@MichaelReyes MichaelReyes deleted the bugfix/23029-handle-remote-icons branch January 20, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants