Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23335] #180

Merged
Merged

Conversation

MichaelReyes
Copy link
Collaborator

Pull Request (PR) Checklist

Thank you for your contribution! Please confirm that you've checked all the boxes below before submitting your PR. Use [x] to check a box, e.g., [x], and make sure there's no space around the brackets.

PR Context

Changes

Describe your changes in detail, highlighting the problem it solves or the feature it adds.

  • [TripKitUI] update MyPersonalDataActivity to replace handling of delete account action to show confirmation dialog and call delete user api on positive action click. Also updated it to extend the class to BaseActivity
  • [TripGov5] add MyPersonalDataUIState.kt to handle UI state
  • [TripGov5] update MyPersonalDataViewModel to inject UserAccountRepository and add function to call delete user api from repository
  • [TripGov5] update SettingsCardFragment to add activityResultLauncher to be passed on SettingsFragment for MyPersonalDataActivity activity result handling
  • [TripGov5] update SettingsFragment to use resultActivityLauncher for MyPersonalDataActivity
  • [TripGov5] update StringUtils.kt to use app name to all string arguments
  • [TripGov5] update TripGoEventBus to add event for sign out trigger
  • [TripGov5] update UserAccountRepository and UserAccountRepositoryImpl to add function for delete user api call
  • update WLSettingsManager to add observer for the sign out event
  • [TripGov5] update NEC application to only instantiate Instabug if build is debug
  • [TripGov5] update AccountModule to only add InstabugOkHttpInterceptor if build is debug
  • [TripKit] update HttpClientModule to only add InstabugOkHttpInterceptor if build is debug

Checklist for Reviewers

Documentation and Code Quality

  • KDocs Documentation: Are all changes, new functionalities, and classes documented with KDocs?
  • Architectural Patterns: Is there consistent and proper use of architectural patterns (e.g., MVVM, MVP)?

Testing and Reliability

  • Unit Testing: Are there unit tests for all new functionalities and classes?
  • Emulator and Real Device Testing: Has the application been tested on both emulators and real devices to ensure compatibility?

Error Handling and Logging

  • Error Handling: Are errors and exceptions caught and handled gracefully, ensuring the app remains stable?
  • Logging: Is there proper logging in place for critical errors and information, aiding in debugging and monitoring?

Testing Procedure

If applicable, provide steps or commands for testing your changes. This can help reviewers and testers.

Work-in-Progress (WIP)

List any remaining work or areas that need additional focus. This section can be updated as the work progresses.

  • [ ]
  • [ ]

Remember to keep this template updated based on the feedback and evolving project standards.

- update submodule reference
Copy link

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

@MichaelReyes MichaelReyes merged commit e971d0a into develop Feb 5, 2025
1 check passed
@MichaelReyes MichaelReyes deleted the bugfix/23335-remove-instabug-instance-on-prod branch February 5, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants