Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23311] Replace flavor name to app name for texts in the app #185

Merged

Conversation

MichaelReyes
Copy link
Collaborator

Pull Request (PR) Checklist

Thank you for your contribution! Please confirm that you've checked all the boxes below before submitting your PR. Use [x] to check a box, e.g., [x], and make sure there's no space around the brackets.

PR Context

Changes

Describe your changes in detail, highlighting the problem it solves or the feature it adds.

  • [TripGov5] update MyPersonalDataActivity to use app name instead of flavor name in the notice
  • [TripGov5] update StringUtils.kt to add extension for app name.
  • [TripKitUI] remove wrong packages for translation

Checklist for Reviewers

Documentation and Code Quality

  • KDocs Documentation: Are all changes, new functionalities, and classes documented with KDocs?
  • Architectural Patterns: Is there consistent and proper use of architectural patterns (e.g., MVVM, MVP)?

Testing and Reliability

  • Unit Testing: Are there unit tests for all new functionalities and classes?
  • Emulator and Real Device Testing: Has the application been tested on both emulators and real devices to ensure compatibility?

Error Handling and Logging

  • Error Handling: Are errors and exceptions caught and handled gracefully, ensuring the app remains stable?
  • Logging: Is there proper logging in place for critical errors and information, aiding in debugging and monitoring?

Testing Procedure

If applicable, provide steps or commands for testing your changes. This can help reviewers and testers.

Work-in-Progress (WIP)

List any remaining work or areas that need additional focus. This section can be updated as the work progresses.

  • [ ]
  • [ ]

Remember to keep this template updated based on the feedback and evolving project standards.

crowdin-bot and others added 2 commits February 4, 2025 10:42
- [TripGov5] update MyPersonalDataActivity to use app name instead of flavor name in the notice
- [TripGov5] update StringUtils.kt to add extension for app name.
- [TripKitUI] remove wrong packages for translation
Copy link

github-actions bot commented Feb 4, 2025

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

- [TripKitUI] update tripkit-android submodule reference
@MichaelReyes MichaelReyes merged commit 515016d into develop Feb 5, 2025
1 check passed
@MichaelReyes MichaelReyes deleted the bugfix/23311-remove-flavor-name-usage-in-texts branch February 5, 2025 05:14
Copy link

github-actions bot commented Feb 5, 2025

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants