Use external templates and html2js preprocessor

skesani · Sep 11, 2012 · 7b7a0b8 · 7b7a0b8
1 parent 44eeddb
commit 7b7a0b8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 15 deletions.
diff --git a/js/tabs.js b/js/tabs.js
@@ -23,16 +23,7 @@ tabs.directive('tabs', function() {
     transclude: true,
     scope: {},
     controller: TabsController,
-    // templateUrl: 'tpl/tabs.html',
-    template:
-      '<div class="tabbable">' +
-        '<ul class="nav nav-tabs">' +
-          '<li ng-repeat="pane in panes" ng-class="{active:pane.selected}">'+
-            '<a href="" ng-click="select(pane)">{{pane.title}}</a>' +
-          '</li>' +
-        '</ul>' +
-        '<div class="tab-content" ng-transclude></div>' +
-      '</div>',
+    templateUrl: 'tpl/tabs.html',
     replace: true
   };
 });
@@ -47,8 +38,7 @@ tabs.directive('pane', function() {
     link: function(scope, element, attrs, tabsCtrl) {
       tabsCtrl.addPane(scope);
     },
-    // templateUrl: 'tpl/pane.html',
-    template: '<div class="tab-pane" ng-class="{active: selected}" ng-transclude></div>',
+    templateUrl: 'tpl/pane.html',
     replace: true
   };
 });
diff --git a/test/tabsSpec.js b/test/tabsSpec.js
@@ -5,7 +5,7 @@ describe('tabs', function() {
   beforeEach(module('tabs'));
 
   // load the templates
-  // beforeEach(module('tpl/tabs.html', 'tpl/pane.html'));
+  beforeEach(module('tpl/tabs.html', 'tpl/pane.html'));
 
   beforeEach(inject(function($rootScope, $compile) {
     // we might move this tpl into an html file as well...

diff --git a/testacular.conf.js b/testacular.conf.js
@@ -22,10 +22,14 @@ files = [
   // tests
   'test/*.js',
 
-  // templates generated by grunt
-  'tpl/*.html.js'
+  // templates
+  'tpl/*.html'
 ];
 
+// generate js files from html templates
+preprocessors = {
+  '**/*.html': 'html2js'
+};
 
 // list of files to exclude
 exclude = [];