Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use Caching in Priority Nonce Mempool for Tx Look ups (backport #520) #524

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 18, 2024

Before Optimization:
Screenshot 2024-06-18 at 4 39 30 PM

After Optimization:
Screenshot 2024-06-18 at 4 39 54 PM


This is an automatic backport of pull request #520 done by [Mergify](https://mergify.com).

* benchmark contains

* use sender/nonce when caching

* nit

* nits

* nit

(cherry picked from commit 3376dd3)

# Conflicts:
#	block/base/mempool_test.go
@mergify mergify bot added the conflicts label Jun 18, 2024
Copy link
Author

mergify bot commented Jun 18, 2024

Cherry-pick of 3376dd3 has failed:

On branch mergify/bp/release/v2.x.x/pr-520
Your branch is up to date with 'origin/release/v2.x.x'.

You are currently cherry-picking commit 3376dd3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   block/base/lane.go
	modified:   block/base/mempool.go
	modified:   block/base/options.go
	modified:   block/base/priority_nonce.go
	modified:   lanes/base/mempool_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   block/base/mempool_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/v2.x.x@72a11dc). Learn more about missing BASE report.

Files Patch % Lines
block/base/priority_nonce.go 0.00% 11 Missing ⚠️
block/base/mempool.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/v2.x.x     #524   +/-   ##
=================================================
  Coverage                  ?   49.10%           
=================================================
  Files                     ?       39           
  Lines                     ?     1682           
  Branches                  ?        0           
=================================================
  Hits                      ?      826           
  Misses                    ?      766           
  Partials                  ?       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidterpay davidterpay merged commit d076b5e into release/v2.x.x Jun 19, 2024
11 of 12 checks passed
@davidterpay davidterpay deleted the mergify/bp/release/v2.x.x/pr-520 branch June 19, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant