fixed scaleFromCenter and aspectRatio bug #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the scaleFromCenter and aspectRatio flags weren't working as I expected. I thought they would be flags that changed the default behavior of the transformation, but instead it was just the initial value from the mousedown event.
To fix it, I refactored a bit. Instead of manually specifying this
you can just do this:
That allows us to utilize
startFromCenter
andaspectRatio
for specifying their default behavior. If we set either to true, alt/shift will still toggle, just in the other direction.For the future, another capability that might be nice would be to allow
startFromCenter
andaspectRatio
to be locked. Currently there isenableStartFromCenter=false
which would disable scale from center, but it might be nice to be able to disable scale from corner and only allow scaling from the center. An easy thought would be to use something along the lines ofenableStartFromCenter=[false|null|true]
for specifying [scale from corner, toggleable, scale from center], though naming that argument might be a challenge.