Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1221] Fix scaling calculation in MASE - unpack encoder_target sequence #1230

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

MBelniak
Copy link
Contributor

Description

This PR ...

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

Make sure to have fun coding!

@MBelniak
Copy link
Contributor Author

Fixes #1221

Copy link
Collaborator

@jdb78 jdb78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.08% 🎉

Comparison is base (b4ce1cf) 90.11% compared to head (01f1ca1) 90.19%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1230      +/-   ##
==========================================
+ Coverage   90.11%   90.19%   +0.08%     
==========================================
  Files          30       30              
  Lines        4714     4714              
==========================================
+ Hits         4248     4252       +4     
+ Misses        466      462       -4     
Flag Coverage Δ
cpu 90.19% <100.00%> (+0.08%) ⬆️
pytest 90.19% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pytorch_forecasting/metrics/point.py 91.91% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdb78 jdb78 merged commit bb69ebd into sktime:master Sep 10, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants